Refactor CSS property mapping for SMIL Animation

Refactor CSS property mapping for SMIL Animation

Currently the SMIL code relies on 'attributeName' mapping 1:1 to the
CSS property name. This would not work with for instance with
'gradientTransform', which is supposed to map to the 'transform'
property.

To support this, store a CSS property id in SVGAnimatedTypeAnimator, and
use the CSS property id stored in SVGAnimatedProperty to populate it when
possible (using the current method in other cases.)

While doing this, also remove the stored 'context element' from
SVGAnimatedTypeAnimator, since it's only used in the reset(...) method,
and hence can simply be passed as an argument.

Also cleanup the uses of a CSSPropertyID in SVGAnimateElement (the sole
user of SVGAnimatedTypeAnimator) by using the stored CSS property id.

Make SVGAnimateElement::shouldApplyAnimation return bool, and use the
data from the SVGAnimatedTypeAnimator instead to determine which
animation code-path to use.

BUG=369942, 641437
Committed: https://crrev.com/2b7933079a764258e89426a1f81645076fc6910d
Cr-Commit-Position: refs/heads/master@{#431862}

[fs, 2016-11-10 16:22:10]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 16:22:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-11-10 17:39:17]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:23:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:23:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2016-11-10 19:47:10]

On 2016/11/10 at 17:39:18, fs wrote:
> 

Looks great but isn't this a behavior change? Can you add a test?

[fs, 2016-11-11 09:40:51]

On 2016/11/10 at 19:47:10, pdr wrote:
> On 2016/11/10 at 17:39:18, fs wrote:
> > 
> 
> Looks great but isn't this a behavior change? Can you add a test?

Very mildly so - to such as a degree as to not be usefully noticeable I think
even. I'm assuming you're thinking of the removal of
isPresentationAttributeWithSVGDOM? If not, then I'm at a loss =). (I think we
should consider stricter handling of 'attributeType' for that case, so that we
can avoid the "animate both ways" mechanism.)

[pdr., 2016-11-11 19:35:21]

On 2016/11/11 at 09:40:51, fs wrote:
> On 2016/11/10 at 19:47:10, pdr wrote:
> > On 2016/11/10 at 17:39:18, fs wrote:
> > > 
> > 
> > Looks great but isn't this a behavior change? Can you add a test?
> 
> Very mildly so - to such as a degree as to not be usefully noticeable I think
even. I'm assuming you're thinking of the removal of
isPresentationAttributeWithSVGDOM? If not, then I'm at a loss =). (I think we
should consider stricter handling of 'attributeType' for that case, so that we
can avoid the "animate both ways" mechanism.)

OK SGTM LGTM

[fs, 2016-11-14 10:17:15]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-11-14 10:17:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 11:47:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-14 11:49:32]

Description was changed from

==========
Refactor CSS property mapping for SMIL Animation

Currently the SMIL code relies on 'attributeName' mapping 1:1 to the
CSS property name. This would not work with for instance with
'gradientTransform', which is supposed to map to the 'transform'
property.

To support this, store a CSS property id in SVGAnimatedTypeAnimator, and
use the CSS property id stored in SVGAnimatedProperty to populate it when
possible (using the current method in other cases.)

While doing this, also remove the stored 'context element' from
SVGAnimatedTypeAnimator, since it's only used in the reset(...) method,
and hence can simply be passed as an argument.

Also cleanup the uses of a CSSPropertyID in SVGAnimateElement (the sole
user of SVGAnimatedTypeAnimator) by using the stored CSS property id.

Make SVGAnimateElement::shouldApplyAnimation return bool, and use the
data from the SVGAnimatedTypeAnimator instead to determine which
animation code-path to use.

BUG=369942,641437
==========

to

==========
Refactor CSS property mapping for SMIL Animation

Currently the SMIL code relies on 'attributeName' mapping 1:1 to the
CSS property name. This would not work with for instance with
'gradientTransform', which is supposed to map to the 'transform'
property.

To support this, store a CSS property id in SVGAnimatedTypeAnimator, and
use the CSS property id stored in SVGAnimatedProperty to populate it when
possible (using the current method in other cases.)

While doing this, also remove the stored 'context element' from
SVGAnimatedTypeAnimator, since it's only used in the reset(...) method,
and hence can simply be passed as an argument.

Also cleanup the uses of a CSSPropertyID in SVGAnimateElement (the sole
user of SVGAnimatedTypeAnimator) by using the stored CSS property id.

Make SVGAnimateElement::shouldApplyAnimation return bool, and use the
data from the SVGAnimatedTypeAnimator instead to determine which
animation code-path to use.

BUG=369942,641437

Committed: https://crrev.com/2b7933079a764258e89426a1f81645076fc6910d
Cr-Commit-Position: refs/heads/master@{#431862}
==========

[commit-bot: I haz the power, 2016-11-14 11:49:33]

Patchset 1 (id:??) landed as
https://crrev.com/2b7933079a764258e89426a1f81645076fc6910d
Cr-Commit-Position: refs/heads/master@{#431862}