Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2496583002: Refactor CSS property mapping for SMIL Animation (Closed)

Created:
4 years, 1 month ago by fs
Modified:
4 years, 1 month ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor CSS property mapping for SMIL Animation Currently the SMIL code relies on 'attributeName' mapping 1:1 to the CSS property name. This would not work with for instance with 'gradientTransform', which is supposed to map to the 'transform' property. To support this, store a CSS property id in SVGAnimatedTypeAnimator, and use the CSS property id stored in SVGAnimatedProperty to populate it when possible (using the current method in other cases.) While doing this, also remove the stored 'context element' from SVGAnimatedTypeAnimator, since it's only used in the reset(...) method, and hence can simply be passed as an argument. Also cleanup the uses of a CSSPropertyID in SVGAnimateElement (the sole user of SVGAnimatedTypeAnimator) by using the stored CSS property id. Make SVGAnimateElement::shouldApplyAnimation return bool, and use the data from the SVGAnimatedTypeAnimator instead to determine which animation code-path to use. BUG=369942, 641437 Committed: https://crrev.com/2b7933079a764258e89426a1f81645076fc6910d Cr-Commit-Position: refs/heads/master@{#431862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -85 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.h View 1 chunk +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 10 chunks +42 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp View 3 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
fs
4 years, 1 month ago (2016-11-10 17:39:18 UTC) #4
pdr.
On 2016/11/10 at 17:39:18, fs wrote: > Looks great but isn't this a behavior change? ...
4 years, 1 month ago (2016-11-10 19:47:10 UTC) #7
fs
On 2016/11/10 at 19:47:10, pdr wrote: > On 2016/11/10 at 17:39:18, fs wrote: > > ...
4 years, 1 month ago (2016-11-11 09:40:51 UTC) #8
pdr.
On 2016/11/11 at 09:40:51, fs wrote: > On 2016/11/10 at 19:47:10, pdr wrote: > > ...
4 years, 1 month ago (2016-11-11 19:35:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496583002/1
4 years, 1 month ago (2016-11-14 10:17:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 11:47:28 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 11:49:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b7933079a764258e89426a1f81645076fc6910d
Cr-Commit-Position: refs/heads/master@{#431862}

Powered by Google App Engine
This is Rietveld 408576698