Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.h

Issue 2496583002: Refactor CSS property mapping for SMIL Animation (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 5 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 enum AttributeType { AttributeTypeCSS, AttributeTypeXML, AttributeTypeAuto }; 82 enum AttributeType { AttributeTypeCSS, AttributeTypeXML, AttributeTypeAuto };
83 AttributeType getAttributeType() const { return m_attributeType; } 83 AttributeType getAttributeType() const { return m_attributeType; }
84 84
85 FRIEND_TEST_ALL_PREFIXES(UnsafeSVGAttributeSanitizationTest, 85 FRIEND_TEST_ALL_PREFIXES(UnsafeSVGAttributeSanitizationTest,
86 stringsShouldNotSupportAddition); 86 stringsShouldNotSupportAddition);
87 87
88 private: 88 private:
89 void resetAnimatedPropertyType(); 89 void resetAnimatedPropertyType();
90 90
91 enum ShouldApplyAnimationType { 91 bool shouldApplyAnimation(const SVGElement& targetElement,
92 DontApplyAnimation, 92 const QualifiedName& attributeName);
93 ApplyCSSAnimation,
94 ApplyXMLAnimation,
95 ApplyXMLandCSSAnimation
96 };
97
98 ShouldApplyAnimationType shouldApplyAnimation(
99 SVGElement* targetElement,
100 const QualifiedName& attributeName);
101 93
102 void setAttributeType(const AtomicString&); 94 void setAttributeType(const AtomicString&);
103 95
104 void checkInvalidCSSAttributeType(); 96 void checkInvalidCSSAttributeType();
105 bool hasInvalidCSSAttributeType() const { 97 bool hasInvalidCSSAttributeType() const {
106 return m_hasInvalidCSSAttributeType; 98 return m_hasInvalidCSSAttributeType;
107 } 99 }
108 bool hasValidTarget() final; 100 bool hasValidTarget() final;
109 bool hasValidAttributeName() const; 101 bool hasValidAttributeName() const;
110 virtual bool hasValidAttributeType(); 102 virtual bool hasValidAttributeType();
(...skipping 18 matching lines...) Expand all
129 return element.hasTagName(SVGNames::animateTag) || 121 return element.hasTagName(SVGNames::animateTag) ||
130 element.hasTagName(SVGNames::animateTransformTag) || 122 element.hasTagName(SVGNames::animateTransformTag) ||
131 element.hasTagName(SVGNames::setTag); 123 element.hasTagName(SVGNames::setTag);
132 } 124 }
133 125
134 DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION(SVGAnimateElement); 126 DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION(SVGAnimateElement);
135 127
136 } // namespace blink 128 } // namespace blink
137 129
138 #endif // SVGAnimateElement_h 130 #endif // SVGAnimateElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698