Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2496383002: GN: Make sure we use clang when ASAN is specificed for ia32 Linux (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Make sure we use clang when ASAN is specificed for ia32 Linux R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f765e1498fdffbcc99a621edf83cd6a38c3c1e6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gn.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 1 month ago (2016-11-14 19:21:42 UTC) #2
Cutch
lgtm
4 years, 1 month ago (2016-11-14 20:56:18 UTC) #3
zra
4 years, 1 month ago (2016-11-14 21:29:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f765e1498fdffbcc99a621edf83cd6a38c3c1e6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698