Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: tools/gn.py

Issue 2496383002: GN: Make sure we use clang when ASAN is specificed for ia32 Linux (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn.py
diff --git a/tools/gn.py b/tools/gn.py
index 2ff3bc27f333d4989ef172e19693bda1d2b37eca..304bdaaf5b7dfd11b5c3564338f5f6f7e5433a91 100755
--- a/tools/gn.py
+++ b/tools/gn.py
@@ -112,7 +112,8 @@ def to_gn_args(args, mode, arch, target_os):
has_clang = (host_os != 'win'
and args.os not in ['android']
and not (gn_args['target_os'] == 'linux' and
- gn_args['host_cpu'] == 'x86')
+ gn_args['host_cpu'] == 'x86' and
+ not args.asan) # Use clang for asan builds.
and not gn_args['target_cpu'].startswith('arm')
and not gn_args['target_cpu'].startswith('mips'))
gn_args['is_clang'] = args.clang and has_clang
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698