Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2496233003: Destroy the old RenderWidgetHostView when swapping out a main frame. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index a17b198447e048b9986418c4b6d3446bfc040ba4..9f4ad688f76f808f49d4bf715b1c399631d62882 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1402,8 +1402,6 @@ void RenderFrameHostImpl::SwapOut(
// TODO(nasko): If the frame is not live, the RFH should just be deleted by
// simulating the receipt of swap out ack.
is_waiting_for_swapout_ack_ = true;
- if (frame_tree_node_->IsMainFrame())
- render_view_host_->set_is_active(false);
}
void RenderFrameHostImpl::OnBeforeUnloadACK(
@@ -1570,13 +1568,6 @@ void RenderFrameHostImpl::OnSwappedOut() {
ClearAllWebUI();
- // If this is a main frame RFH that's about to be deleted, update its RVH's
- // swapped-out state here. https://crbug.com/505887
- if (frame_tree_node_->IsMainFrame()) {
- render_view_host_->set_is_active(false);
- render_view_host_->set_is_swapped_out(true);
- }
-
bool deleted =
frame_tree_node_->render_manager()->DeleteFromPendingList(this);
CHECK(deleted);

Powered by Google App Engine
This is Rietveld 408576698