Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: chrome/browser/search/search_unittest.cc

Issue 2496233003: Destroy the old RenderWidgetHostView when swapping out a main frame. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/search_unittest.cc
diff --git a/chrome/browser/search/search_unittest.cc b/chrome/browser/search/search_unittest.cc
index 1761130c99d8e1926462d9ce02a00d2dac8b94d9..4c0ba0b1c053cda37045ee94d2683809fc788a7a 100644
--- a/chrome/browser/search/search_unittest.cc
+++ b/chrome/browser/search/search_unittest.cc
@@ -44,6 +44,10 @@
#include "chrome/browser/supervised_user/supervised_user_url_filter.h"
#endif
+#if defined(OS_MACOSX)
+#include "ui/accelerated_widget_mac/window_resize_helper_mac.h"
+#endif
+
namespace search {
class SearchTest : public BrowserWithTestWindowTest {
@@ -58,6 +62,18 @@ class SearchTest : public BrowserWithTestWindowTest {
TemplateURLServiceFactory::GetForProfile(profile());
search_test_utils::WaitForTemplateURLServiceToLoad(template_url_service);
SetSearchProvider(true, false);
+
+#if defined(OS_MACOSX)
+ ui::WindowResizeHelperMac::Get()->Init(base::ThreadTaskRunnerHandle::Get());
Charlie Reis 2016/11/23 07:25:22 Just for the record, what made this test change ne
lfg 2016/11/29 17:41:22 Search test performs multiple navigations, in part
Charlie Reis 2016/11/29 19:35:55 Hmm, I don't follow. Lots of tests do multiple na
+#endif // OS_MACOSX
+ }
+
+ void TearDown() override {
+#if defined(OS_MACOSX)
+ ui::WindowResizeHelperMac::Get()->ShutdownForTests();
+#endif // OS_MACOSX
+
+ BrowserWithTestWindowTest::TearDown();
}
virtual void SetSearchProvider(bool set_ntp_url, bool insecure_ntp_url) {
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/public/test/test_renderer_host.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698