Add printing tests to ensure window.print() works for subframes.

Add printing tests to ensure window.print() works for subframes.

BUG=631513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

[Lei Zhang, 2016-11-15 03:09:33]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2016-11-15 03:09:49]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[Lei Zhang, 2016-11-15 03:10:56]

Description was changed from

==========
Add printing tests to ensure window.print() works for subframes.

BUG=631513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add printing tests to ensure window.print() works for subframes.

BUG=631513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-11-15 03:11:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-15 03:12:57]

Follow up to https://codereview.chromium.org/2426503002 to add a full browser
test. The content/ changes can be dropped if we allow more non-const RFH
pointers.

[commit-bot: I haz the power, 2016-11-15 04:04:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 04:04:55]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-11-18 07:30:31]

thestig@chromium.org changed reviewers:
+ nasko@chromium.org

[Lei Zhang, 2016-11-18 07:30:32]

Don't forget the test.

[nasko, 2016-11-18 19:19:42]

https://codereview.chromium.org/2496203003/diff/20001/chrome/browser/printing...
File chrome/browser/printing/print_view_manager_browsertest.cc (right):

https://codereview.chromium.org/2496203003/diff/20001/chrome/browser/printing...
chrome/browser/printing/print_view_manager_browsertest.cc:109:
IN_PROC_BROWSER_TEST_F(PrintViewManagerTest, SubframeWindowDotPrint) {
Put a small comment describing what this test is aiming to verify. If I get it
correctly, it only verifies that the scripted print was received through the
RenderFrameHost IPC, right?

https://codereview.chromium.org/2496203003/diff/20001/chrome/browser/printing...
chrome/browser/printing/print_view_manager_browsertest.cc:110: {
Why have this nested scope when it includes all the code?

https://codereview.chromium.org/2496203003/diff/20001/chrome/browser/printing...
chrome/browser/printing/print_view_manager_browsertest.cc:123:
embedded_test_server()->port());
You can just call embedded_test_server()->GetURL("c.com",
"/printing/window_print.html"); I've added it to embedded_test_server to avoid
this specific code pattern, as it is less readable.

https://codereview.chromium.org/2496203003/diff/20001/chrome/browser/printing...
chrome/browser/printing/print_view_manager_browsertest.cc:126:
requests[0].render_frame_host));
Why not check that the specific RenderFrameHost is the expected one? You could
get all frames from WebContents and pick the one with the name you've given in
the HTML file.