content/browser/frame_host/render_frame_host_impl.cc - Issue 2496203003: Add printing tests to ensure window.print() works for subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2496203003: Add printing tests to ensure window.print() works for subframes.

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 4d0821ed925801b2084dc650573ca6fa1b5bd91f..74e65279e1224a02c97c6efdc22005e316ff31d1 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -435,7 +435,7 @@ bool RenderFrameHostImpl::IsCrossProcessSubframe() {

return GetSiteInstance() != parent_->GetSiteInstance();

}

-const GURL& RenderFrameHostImpl::GetLastCommittedURL() {

+const GURL& RenderFrameHostImpl::GetLastCommittedURL() const {

return last_committed_url();

}