DOM: Remove standard-violating optimizations in appendChild, insertBefore, and replaceChild.

DOM: Remove standard-violating optimizations in appendChild, insertBefore, and replaceChild.

These functions did nothing in some cases; e.g. node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

The new behavior matches to Firefox and Safari.

Test changes:
* http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
  appendChild() confuses the test. It's just unnecessary. See crbug.com/664992.

* plugins/reattach-plugin-during-access.html
 divElem.appendChild(objElem) was executed repeatedly. Once is enough.

* paint/invalidation/svg/tabgroup.svg
  We have more paint due to the removal of the optimization.


BUG=441355, 664992
Review-Url: https://codereview.chromium.org/2496133002
Cr-Commit-Position: refs/heads/master@{#448928}
Committed: https://chromium.googlesource.com/chromium/src/+/1c12127b721f833f37b81553e19b8eb0392da651

[tkent, 2016-11-14 08:05:43]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 08:05:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-11-14 08:24:05]

Description was changed from

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL just removes the optimizations, and a test
MutationObserver-childList.html still fails because of another issue.

BUG=441355
==========

to

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL just removes the optimizations. a test MutationObserver-childList.html
still fails because of another issue.

BUG=441355
==========

[tkent, 2016-11-14 08:25:16]

Description was changed from

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL just removes the optimizations. a test MutationObserver-childList.html
still fails because of another issue.

BUG=441355
==========

to

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL just removes the optimizations, and fixes a timeout in
MutationObserver-childList.html.
However, the test still fails because of another issue.

BUG=441355
==========

[tkent, 2016-11-14 08:26:06]

Description was changed from

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL just removes the optimizations, and fixes a timeout in
MutationObserver-childList.html.
However, the test still fails because of another issue.

BUG=441355
==========

to

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

BUG=441355
==========

[commit-bot: I haz the power, 2016-11-14 09:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 09:07:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-02-08 04:07:54]

Description was changed from

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

BUG=441355
==========

to

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

BUG=441355, 664992
==========

[tkent, 2017-02-08 04:09:17]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 04:09:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-08 04:12:49]

Patchset #1 (id:1) has been deleted

[tkent, 2017-02-08 05:27:52]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 05:28:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-08 05:35:27]

Description was changed from

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

BUG=441355, 664992
==========

to

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

The new behavior matches to Firefox and Safari.

Test changes:
* http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
  appendChild() confuses the test. It's just unnecessary.

* plugins/reattach-plugin-during-access.html
 divElem.appendChild(objElem) was executed repeatedly. Once is enough.

* paint/invalidation/svg/tabgroup.svg
  We have more paint due to the removal of the optimization.



BUG=441355, 664992
==========

[tkent, 2017-02-08 05:35:46]

Description was changed from

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

The new behavior matches to Firefox and Safari.

Test changes:
* http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
  appendChild() confuses the test. It's just unnecessary.

* plugins/reattach-plugin-during-access.html
 divElem.appendChild(objElem) was executed repeatedly. Once is enough.

* paint/invalidation/svg/tabgroup.svg
  We have more paint due to the removal of the optimization.



BUG=441355, 664992
==========

to

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

The new behavior matches to Firefox and Safari.

Test changes:
* http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
  appendChild() confuses the test. It's just unnecessary. See crbug.com/664992.

* plugins/reattach-plugin-during-access.html
 divElem.appendChild(objElem) was executed repeatedly. Once is enough.

* paint/invalidation/svg/tabgroup.svg
  We have more paint due to the removal of the optimization.



BUG=441355, 664992
==========

[tkent, 2017-02-08 05:53:22]

Patchset #1 (id:20001) has been deleted

[tkent, 2017-02-08 06:17:31]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2017-02-08 06:17:31]

yosin@, yoichio@, would you review this please?

[tkent, 2017-02-08 06:17:41]

Description was changed from

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

The new behavior matches to Firefox and Safari.

Test changes:
* http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
  appendChild() confuses the test. It's just unnecessary. See crbug.com/664992.

* plugins/reattach-plugin-during-access.html
 divElem.appendChild(objElem) was executed repeatedly. Once is enough.

* paint/invalidation/svg/tabgroup.svg
  We have more paint due to the removal of the optimization.



BUG=441355, 664992
==========

to

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

The new behavior matches to Firefox and Safari.

Test changes:
* http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
  appendChild() confuses the test. It's just unnecessary. See crbug.com/664992.

* plugins/reattach-plugin-during-access.html
 divElem.appendChild(objElem) was executed repeatedly. Once is enough.

* paint/invalidation/svg/tabgroup.svg
  We have more paint due to the removal of the optimization.


BUG=441355, 664992
==========

[yosin_UTC9, 2017-02-08 06:28:48]

lgtm

[yosin_UTC9, 2017-02-08 06:28:58]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-08 06:29:01]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-08 06:29:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 07:22:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486535341728540,
"parent_rev": "a79a95466df9d013721167cf2f0c8ba849214207", "commit_rev":
"1c12127b721f833f37b81553e19b8eb0392da651"}

[commit-bot: I haz the power, 2017-02-08 07:23:01]

Description was changed from

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

The new behavior matches to Firefox and Safari.

Test changes:
* http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
  appendChild() confuses the test. It's just unnecessary. See crbug.com/664992.

* plugins/reattach-plugin-during-access.html
 divElem.appendChild(objElem) was executed repeatedly. Once is enough.

* paint/invalidation/svg/tabgroup.svg
  We have more paint due to the removal of the optimization.


BUG=441355, 664992
==========

to

==========
DOM: Remove standard-violating optimizations in appendChild, insertBefore, and
replaceChild.

These functions did nothing in some cases; e.g.
node.appendChild(node.lastChild).
However, it violates the DOM standard, and is not interoperable.

This CL removes the optimizations, and fixes a timeout in MutationObserver-
childList.html.  However, the test still fails because of another issue.

The new behavior matches to Firefox and Safari.

Test changes:
* http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
  appendChild() confuses the test. It's just unnecessary. See crbug.com/664992.

* plugins/reattach-plugin-during-access.html
 divElem.appendChild(objElem) was executed repeatedly. Once is enough.

* paint/invalidation/svg/tabgroup.svg
  We have more paint due to the removal of the optimization.


BUG=441355, 664992

Review-Url: https://codereview.chromium.org/2496133002
Cr-Commit-Position: refs/heads/master@{#448928}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c12127b721f833f37b81553e19b...
==========

[commit-bot: I haz the power, 2017-02-08 07:23:03]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1c12127b721f833f37b81553e19b...