Rename WebKitFinder -> BlinkFinder.

Rename WebKitFinder -> BlinkFinder.

This is part of a general effort to rename things from WebKit to Blink.

This change includes:

  Module webkit_finder -> blink_finder
  Class WebKitFinder -> BlinkFinder
  Method webkit_base -> blink_base
  Method path_from_webkit_base -> path_from_blink_base

BUG=652114

[qyearsley, 2016-11-13 19:57:04]

Description was changed from

==========
Rename WebKitFinder -> BlinkFinder.

This is part of a general effort to rename things from WebKit to Blink.

BUG=652114
==========

to

==========
Rename WebKitFinder -> BlinkFinder.

This is part of a general effort to rename things from WebKit to Blink.

This change includes:

  Module webkit_finder -> blink_finder
  Class WebKitFinder -> BlinkFinder
  Method webkit_base -> blink_base
  Method path_from_webkit_base -> path_from_blink_base

BUG=652114
==========

[qyearsley, 2016-11-13 19:57:04]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-11-14 00:27:50]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 00:28:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 01:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 01:32:45]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-11-14 18:36:02]

Hi Dirk, this was a change I started before, and is related to the discussion on
http://crrev.com/2497793002 -- although it's just related to "blink" vs
"webkit", not related to what "layout tests" should be called.

Any thoughts about this renaming?

[Dirk Pranke, 2016-11-14 20:36:18]

I don't think this is a good idea. In particular, I think using "blink_base" to
refer to third_party/WebKit is probably confusing to most Blink devs,
particularly since there is also a (mostly empty) //blink directory.

[qyearsley, 2016-11-14 21:00:46]

On 2016/11/14 at 20:36:18, dpranke wrote:
> I don't think this is a good idea. In particular, I think using "blink_base"
to refer to third_party/WebKit is probably confusing to most Blink devs,
particularly since there is also a (mostly empty) //blink directory.

Makes sense; perhaps someday if third_party/WebKit could be moved to src/blink,
then this would be a clearer change to make.

[jeffcarp, 2016-11-14 21:14:23]

On 2016/11/14 at 21:00:46, qyearsley wrote:
> On 2016/11/14 at 20:36:18, dpranke wrote:
> > I don't think this is a good idea. In particular, I think using "blink_base"
to refer to third_party/WebKit is probably confusing to most Blink devs,
particularly since there is also a (mostly empty) //blink directory.
> 
> Makes sense; perhaps someday if third_party/WebKit could be moved to
src/blink, then this would be a clearer change to make.

Is src/blink or blink/ the end-goal directory? (I was under the impression it
was the latter)

[Dirk Pranke, 2016-11-14 21:19:55]

On 2016/11/14 21:14:23, jeffcarp wrote:
> On 2016/11/14 at 21:00:46, qyearsley wrote:
> > On 2016/11/14 at 20:36:18, dpranke wrote:
> > > I don't think this is a good idea. In particular, I think using
"blink_base"
> to refer to third_party/WebKit is probably confusing to most Blink devs,
> particularly since there is also a (mostly empty) //blink directory.
> > 
> > Makes sense; perhaps someday if third_party/WebKit could be moved to
> src/blink, then this would be a clearer change to make.
> 
> Is src/blink or blink/ the end-goal directory? (I was under the impression it
> was the latter)

"//blink" comes from the GN notation (also the Bazel/Blaze notation), which
means 
"relative to the top of the repo". The Chromium repo is called "src", so
"//blink"
is the same thing as "src/blink". It might also be the same thing as "blink/",
I'm not
sure what you're thinking of, but "blink" definitely won't be a sibling of
"src".