third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py - Issue 2496063002: Rename WebKitFinder -> BlinkFinder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

Issue 2496063002: Rename WebKitFinder -> BlinkFinder. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

index 9108c4cf4ed56d3ec0de8d6d5be5ef194aaecb9b..8304a9895227c253ccdc483e41f16295ae0b5215 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

@@ -33,7 +33,7 @@ import sys

from webkitpy.common.system.executive import Executive

from webkitpy.common.system.filesystem import FileSystem

-from webkitpy.common.webkit_finder import WebKitFinder

+from webkitpy.common.blink_finder import BlinkFinder

_log = logging.getLogger(__name__)

@@ -54,7 +54,7 @@ class Bisector(object):

self.tests = tests

self.expected_failure = tests[-1]

self.is_debug = is_debug

- self.webkit_finder = WebKitFinder(FileSystem())

+ self.blink_finder = BlinkFinder(FileSystem())

def bisect(self):

if self.test_fails_in_isolation():

@@ -145,7 +145,7 @@ class Bisector(object):

def test_fails(self, tests):

extra_args = ['--debug'] if self.is_debug else []

- path_to_run_webkit_tests = self.webkit_finder.path_from_webkit_base('Tools', 'Scripts', 'run-webkit-tests')

+ path_to_run_webkit_tests = self.blink_finder.path_from_blink_base('Tools', 'Scripts', 'run-webkit-tests')

output = self.executive.popen(

[path_to_run_webkit_tests, '--child-processes', '1', '--order', 'none', '--no-retry',

'--no-show-results', '--verbose'] + extra_args + tests, stdout=subprocess.PIPE, stderr=subprocess.PIPE)