Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2496043004: Revert of Tablet-like power button behavior on Convertible/Tablet ChromeOS devices (Closed)

Created:
4 years, 1 month ago by horo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Tablet-like power button behavior on Convertible/Tablet ChromeOS devices (patchset #12 id:300001 of https://codereview.chromium.org/2474913004/ ) Reason for revert: Caused failures of AshTestHelperTest.AshTestHelper in ash_unittests. See http://crbug.com/665278 BUG=665278 Original issue's description: > Tablet-like power button behavior on Convertible/Tablet ChromeOS devices > > Changes: > device consistency: convertible/tablet chromeos devices follow the behavior described in go/touchview-power convertible behavior; other devices follow clamshell behavior. > > BUG=633304 > TEST=manually test; add unitttest > > Committed: https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178 > Cr-Commit-Position: refs/heads/master@{#431931} TBR=derat@chromium.org,warx@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633304 Committed: https://crrev.com/2b31faaf2a38e64e3950e40f9558ece3fdef4307 Cr-Commit-Position: refs/heads/master@{#432089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -703 lines) Patch
M ash/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D ash/system/chromeos/power/tablet_power_button_controller.h View 1 chunk +0 lines, -122 lines 0 comments Download
D ash/system/chromeos/power/tablet_power_button_controller.cc View 1 chunk +0 lines, -212 lines 0 comments Download
D ash/system/chromeos/power/tablet_power_button_controller_unittest.cc View 1 chunk +0 lines, -306 lines 0 comments Download
M ash/wm/lock_state_controller.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M ash/wm/power_button_controller.h View 5 chunks +13 lines, -14 lines 0 comments Download
M ash/wm/power_button_controller.cc View 8 chunks +33 lines, -35 lines 0 comments Download
M chromeos/dbus/fake_power_manager_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_power_manager_client.cc View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
horo
Created Revert of Tablet-like power button behavior on Convertible/Tablet ChromeOS devices
4 years, 1 month ago (2016-11-15 03:56:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496043004/1
4 years, 1 month ago (2016-11-15 03:57:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 03:58:22 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2b31faaf2a38e64e3950e40f9558ece3fdef4307 Cr-Commit-Position: refs/heads/master@{#432089}
4 years, 1 month ago (2016-11-15 04:02:48 UTC) #7
Daniel Erat
4 years, 1 month ago (2016-11-15 15:11:24 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698