Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2496013002: Make a bitmaprenderer canvas an ImageSource (Closed)

Created:
4 years, 1 month ago by xidachen
Modified:
4 years, 1 month ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make a bitmaprenderer canvas an ImageSource At this moment, we cannot correct handle drawImage or createImageBitmap with a source canvas that is associated with an ImageBitmapRenderingContext. This CL makes sure that the canvas can be an ImageSource. Layout tests are added. BUG=663793 Committed: https://crrev.com/48c029113eb4338243d99dbc76f85896be8f3a22 Cr-Commit-Position: refs/heads/master@{#431950}

Patch Set 1 #

Patch Set 2 : remove the expected.txt because the test is passing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/bitmaprenderer-as-imagesource.html View 1 chunk +114 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
xidachen
PTAL. Turns out the changes are relatively small.
4 years, 1 month ago (2016-11-13 03:20:13 UTC) #2
Justin Novosad
lgtm BTW, You just made me realize that I need to make placeholder canvases work ...
4 years, 1 month ago (2016-11-14 17:44:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496013002/20001
4 years, 1 month ago (2016-11-14 20:26:52 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 23:10:39 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 23:12:59 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48c029113eb4338243d99dbc76f85896be8f3a22
Cr-Commit-Position: refs/heads/master@{#431950}

Powered by Google App Engine
This is Rietveld 408576698