Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2495983002:
webrtc-internals: rename mediadescriptor label (Closed)
Descriptionwebrtc-internals: rename mediadescriptor label
Renames the MediaStream "label" used e.g. in addStream and
onaddstream to "id" to be more aligned with the specification.
BUG=none
Committed: https://crrev.com/e491471a75e86466945bc2a43a5c7645efdd95ba
Cr-Commit-Position: refs/heads/master@{#437863}
Patch Set 1 #
Total comments: 1
Patch Set 2 : update AUTHORS #Messages
Total messages: 21 (11 generated)
Description was changed from ========== webrtc-internals: rename mediadescriptor label Renames the MediaStream "label" used e.g. in addStream and onaddstream to "id" to be more aligned with the specification. BUG= ========== to ========== webrtc-internals: rename mediadescriptor label Renames the MediaStream "label" used e.g. in addStream and onaddstream to "id" to be more aligned with the specification. BUG= ==========
philipp.hancke@googlemail.com changed reviewers: + hta@webrtc.org, tommi@webrtc.org
lgtm
tommi@chromium.org changed reviewers: + tommi@chromium.org
fyi - for chromium reviews, you need to send the code reviews to our chromium accounts https://codereview.chromium.org/2495983002/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/2495983002/diff/1/AUTHORS#newcode534 AUTHORS:534: Philipp Hancke <philipp.hancke@gmail.com> philipp.hancke@googlemail.com?
On 2016/12/07 17:13:09, tommi (chrömium) wrote: > fyi - for chromium reviews, you need to send the code reviews to our chromium > accounts > > https://codereview.chromium.org/2495983002/diff/1/AUTHORS > File AUTHORS (right): > > https://codereview.chromium.org/2495983002/diff/1/AUTHORS#newcode534 > AUTHORS:534: Philipp Hancke <mailto:philipp.hancke@gmail.com> > mailto:philipp.hancke@googlemail.com? I added the one used in the commit. Changed to googlemail.com, I assume this will be squashed?
Description was changed from ========== webrtc-internals: rename mediadescriptor label Renames the MediaStream "label" used e.g. in addStream and onaddstream to "id" to be more aligned with the specification. BUG= ========== to ========== webrtc-internals: rename mediadescriptor label Renames the MediaStream "label" used e.g. in addStream and onaddstream to "id" to be more aligned with the specification. BUG=none ==========
The CQ bit was checked by tommi@webrtc.org
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from hta@webrtc.org Link to the patchset: https://codereview.chromium.org/2495983002/#ps20001 (title: "update AUTHORS")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by tommi@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481548130595620,
"parent_rev": "217f5f13ec33fb8c8217fe69f747254e76232bda", "commit_rev":
"ecaea331d15daca1efa1c516b6812b6b0db3ffd7"}
Message was sent while issue was closed.
Description was changed from ========== webrtc-internals: rename mediadescriptor label Renames the MediaStream "label" used e.g. in addStream and onaddstream to "id" to be more aligned with the specification. BUG=none ========== to ========== webrtc-internals: rename mediadescriptor label Renames the MediaStream "label" used e.g. in addStream and onaddstream to "id" to be more aligned with the specification. BUG=none Review-Url: https://codereview.chromium.org/2495983002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== webrtc-internals: rename mediadescriptor label Renames the MediaStream "label" used e.g. in addStream and onaddstream to "id" to be more aligned with the specification. BUG=none Review-Url: https://codereview.chromium.org/2495983002 ========== to ========== webrtc-internals: rename mediadescriptor label Renames the MediaStream "label" used e.g. in addStream and onaddstream to "id" to be more aligned with the specification. BUG=none Committed: https://crrev.com/e491471a75e86466945bc2a43a5c7645efdd95ba Cr-Commit-Position: refs/heads/master@{#437863} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e491471a75e86466945bc2a43a5c7645efdd95ba Cr-Commit-Position: refs/heads/master@{#437863} |
