arc: Convert more Mojo types to STL

arc: Convert more Mojo types to STL

This is the last chunk of services that were trivially migratable. The
rest need either more involvement due to the amount of types, or special
care while migrating due to the presence of type converters.

BUG=624136
TEST=trybots

Committed: https://crrev.com/db94ad755cdc8dd3e4ee8cf4c7e7d43f52117ab7
Cr-Commit-Position: refs/heads/master@{#431767}

[Luis Héctor Chávez, 2016-11-11 21:49:58]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[Luis Héctor Chávez, 2016-11-11 21:50:24]

lhchavez@chromium.org changed reviewers:
+ yusukes@chromium.org

[Luis Héctor Chávez, 2016-11-11 21:50:24]

PTAL as well. This will be my last CL in this series and will hand over the work
to someone else.

[commit-bot: I haz the power, 2016-11-11 21:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 22:01:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 22:01:32]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yusuke Sato, 2016-11-11 22:42:10]

lgtm

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc (right):

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc:8: #include <string>
nit: remove

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc:295:
callback.Run(std::string(json_policies));
remove std::string()? or merge L294 and 295?

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc:304:
callback.Run(std::string("{ \"policyCompliant\": true }"));
same. I think Chromium code usually relies on the implicit constructor.

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc:310:
callback.Run(std::string("{ \"policyCompliant\": false }"));
same

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/policy/arc_policy_bridge.h (right):

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_policy_bridge.h:9: #include <vector>
looks unused

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc (right):

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc:7: #include
<vector>
nit: remove

[Luis Héctor Chávez, 2016-11-12 02:08:01]

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc (right):

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc:8: #include <string>
On 2016/11/11 22:42:10, Yusuke Sato wrote:
> nit: remove

Done.

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc:295:
callback.Run(std::string(json_policies));
On 2016/11/11 22:42:10, Yusuke Sato wrote:
> remove std::string()? or merge L294 and 295?

Done.

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc:304:
callback.Run(std::string("{ \"policyCompliant\": true }"));
On 2016/11/11 22:42:10, Yusuke Sato wrote:
> same. I think Chromium code usually relies on the implicit constructor.

Done.

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc:310:
callback.Run(std::string("{ \"policyCompliant\": false }"));
On 2016/11/11 22:42:10, Yusuke Sato wrote:
> same

Done.

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/policy/arc_policy_bridge.h (right):

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_policy_bridge.h:9: #include <vector>
On 2016/11/11 22:42:10, Yusuke Sato wrote:
> looks unused

Done.

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc (right):

https://codereview.chromium.org/2495913002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc:7: #include
<vector>
On 2016/11/11 22:42:10, Yusuke Sato wrote:
> nit: remove

Done.

[Luis Héctor Chávez, 2016-11-12 02:08:27]

The CQ bit was checked by lhchavez@chromium.org

[Luis Héctor Chávez, 2016-11-12 02:08:28]

The patchset sent to the CQ was uploaded after l-g-t-m from yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2495913002/#ps20001
(title: "Rebased to ToT")

[commit-bot: I haz the power, 2016-11-12 02:08:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 02:56:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 02:56:10]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Luis Héctor Chávez, 2016-11-12 03:17:42]

The CQ bit was checked by lhchavez@chromium.org

[commit-bot: I haz the power, 2016-11-12 03:17:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 04:09:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-12 04:15:31]

Description was changed from

==========
arc: Convert more Mojo types to STL

This is the last chunk of services that were trivially migratable. The
rest need either more involvement due to the amount of types, or special
care while migrating due to the presence of type converters.

BUG=624136
TEST=trybots
==========

to

==========
arc: Convert more Mojo types to STL

This is the last chunk of services that were trivially migratable. The
rest need either more involvement due to the amount of types, or special
care while migrating due to the presence of type converters.

BUG=624136
TEST=trybots

Committed: https://crrev.com/db94ad755cdc8dd3e4ee8cf4c7e7d43f52117ab7
Cr-Commit-Position: refs/heads/master@{#431767}
==========

[commit-bot: I haz the power, 2016-11-12 04:15:32]

Patchset 2 (id:??) landed as
https://crrev.com/db94ad755cdc8dd3e4ee8cf4c7e7d43f52117ab7
Cr-Commit-Position: refs/heads/master@{#431767}