Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: components/arc/metrics/arc_metrics_service.cc

Issue 2495913002: arc: Convert more Mojo types to STL (Closed)
Patch Set: Rebased to ToT Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/metrics/arc_metrics_service.h ('k') | components/arc/obb_mounter/arc_obb_mounter_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/metrics/arc_metrics_service.cc
diff --git a/components/arc/metrics/arc_metrics_service.cc b/components/arc/metrics/arc_metrics_service.cc
index 8ee91605b86441d6744896eb293510ec190d3d98..9914eae04bfbd6fc6d6f27be1b5ed7a22a43944f 100644
--- a/components/arc/metrics/arc_metrics_service.cc
+++ b/components/arc/metrics/arc_metrics_service.cc
@@ -87,10 +87,10 @@ void ArcMetricsService::RequestProcessList() {
}
void ArcMetricsService::ParseProcessList(
- mojo::Array<mojom::RunningAppProcessInfoPtr> processes) {
+ std::vector<mojom::RunningAppProcessInfoPtr> processes) {
int running_app_count = 0;
for (const auto& process : processes) {
- const mojo::String& process_name = process->process_name;
+ const std::string& process_name = process->process_name;
const mojom::ProcessState& process_state = process->process_state;
// Processes like the ARC launcher and intent helper are always running
@@ -98,9 +98,9 @@ void ArcMetricsService::ParseProcessList(
// GMS (Google Play Services) and its related processes are skipped as
// well. The process_state check below filters out system processes,
// services, apps that are cached because they've run before.
- if (base::StartsWith(process_name.get(), kArcProcessNamePrefix,
+ if (base::StartsWith(process_name, kArcProcessNamePrefix,
base::CompareCase::SENSITIVE) ||
- base::StartsWith(process_name.get(), kGmsProcessNamePrefix,
+ base::StartsWith(process_name, kGmsProcessNamePrefix,
base::CompareCase::SENSITIVE) ||
process_state != mojom::ProcessState::TOP) {
VLOG(2) << "Skipped " << process_name << " " << process_state;
@@ -138,14 +138,14 @@ void ArcMetricsService::OnArcStartTimeRetrieved(
}
void ArcMetricsService::ReportBootProgress(
- mojo::Array<mojom::BootProgressEventPtr> events) {
+ std::vector<mojom::BootProgressEventPtr> events) {
DCHECK(CalledOnValidThread());
int64_t arc_start_time_in_ms =
(arc_start_time_ - base::TimeTicks()).InMilliseconds();
for (const auto& event : events) {
VLOG(2) << "Report boot progress event:" << event->event << "@"
<< event->uptimeMillis;
- std::string title = "Arc." + event->event.get();
+ std::string title = "Arc." + event->event;
base::TimeDelta elapsed_time = base::TimeDelta::FromMilliseconds(
event->uptimeMillis - arc_start_time_in_ms);
// Note: This leaks memory, which is expected behavior.
@@ -154,7 +154,7 @@ void ArcMetricsService::ReportBootProgress(
base::TimeDelta::FromSeconds(30), 50,
base::HistogramBase::kUmaTargetedHistogramFlag);
histogram->AddTime(elapsed_time);
- if (event->event.get().compare(kBootProgressEnableScreen) == 0)
+ if (event->event.compare(kBootProgressEnableScreen) == 0)
UMA_HISTOGRAM_CUSTOM_TIMES("Arc.AndroidBootTime", elapsed_time,
base::TimeDelta::FromMilliseconds(1),
base::TimeDelta::FromSeconds(30), 50);
« no previous file with comments | « components/arc/metrics/arc_metrics_service.h ('k') | components/arc/obb_mounter/arc_obb_mounter_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698