Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2495813002: Fix inverted if statement in GLContextEGL. (Closed)

Created:
4 years, 1 month ago by kylechar
Modified:
4 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix inverted if statement in GLContextEGL. The context attributes for IsCreateContextRobustnessSupported got inverted in crrev.com/2480373002. This breaks Ozone X11 running with EGL. BUG=664522 TBR=piman@chromium.org Committed: https://crrev.com/abe74bcd139f934688cc3c892efa350005a7ed41 Cr-Commit-Position: refs/heads/master@{#431574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/gl/gl_context_egl.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
kylechar
TBRing piman for OWNERS. This if statement got inverted in crrev.com/2480373002 and broke Ozone X11 ...
4 years, 1 month ago (2016-11-11 15:14:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495813002/1
4 years, 1 month ago (2016-11-11 15:15:27 UTC) #3
Geoff Lang
Thanks for fixing this.
4 years, 1 month ago (2016-11-11 15:22:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 16:32:44 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abe74bcd139f934688cc3c892efa350005a7ed41 Cr-Commit-Position: refs/heads/master@{#431574}
4 years, 1 month ago (2016-11-11 16:35:28 UTC) #8
piman
4 years, 1 month ago (2016-11-11 23:00:16 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698