Run gl_unittests with Ozone X11.

Run gl_unittests with Ozone X11.

Add a new test target gl_unittests_ozonex that runs with
--ozone-platform=x11. The Ozone CrOS bot will now run gl_unittests with
both Ozone headless and Ozone X11.

The test requires an X server to be running on the bot. The mb.py script
is modified to look for GN arg use_ozone=true and runtime flag
--ozone-platform=x11. In this case, it runs the test using xvfb.

BUG=664570
Committed: https://crrev.com/7895a178293de777611dd91255b9b90934f1a5df
Cr-Commit-Position: refs/heads/master@{#432038}

[kylechar, 2016-11-11 18:52:59]

Description was changed from

==========
Run gl_unittests with Ozone X11.

BUG=TBD
==========

to

==========
Run gl_unittests with Ozone X11.

Add a new test target gl_unittests_ozonex that runs with
--ozone-platform=x11. The Ozone CrOS bot will now run gl_unittests with
both Ozone headless and Ozone X11.

The test requires an X server to be running on the bot. The mb.py script
is modified to look for GN arg use_ozone=true and runtime flag
--ozone-platform=x11. In this case, it runs the test using xvfb.

BUG=664570
==========

[kylechar, 2016-11-11 18:54:58]

kylechar@chromium.org changed reviewers:
+ dpranke@chromium.org

[kylechar, 2016-11-11 18:54:58]

We had talked about this a few months ago. Let me know if anything has changed
in how you think Ozone X11 tests should know to run with xvfb and if there is a
better way to do things.

[Dirk Pranke, 2016-11-11 20:14:16]

Are you adding this because you want coverage of ozone+x11, or because you want
coverage of ozone+x11+chromeos specifically?

You should talk to rjkroege@ and thomasanderson@ if you're more worried about
the former (i.e., for desktop llinux) since they've been working on getting more
coverage of that configuration.

[kylechar, 2016-11-11 20:15:39]

On 2016/11/11 20:14:16, Dirk Pranke wrote:
> Are you adding this because you want coverage of ozone+x11, or because you
want
> coverage of ozone+x11+chromeos specifically?
> 
> You should talk to rjkroege@ and thomasanderson@ if you're more worried about
> the former (i.e., for desktop llinux) since they've been working on getting
more
> coverage of that configuration.

This is for ozone+x11+chromeos specifically. We're relying on that configuration
for the majority of mustash development.

[Dirk Pranke, 2016-11-11 20:28:14]

ok. lgtm.

[kylechar, 2016-11-14 21:17:33]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[kylechar, 2016-11-14 21:17:33]

+sadrul for ui/gl/BUILD.gn change.

[sadrul, 2016-11-14 21:19:35]

lgtm

https://codereview.chromium.org/2493063003/diff/20001/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (right):

https://codereview.chromium.org/2493063003/diff/20001/ui/gl/BUILD.gn#newcode414
ui/gl/BUILD.gn:414: # TODO(GYP_GONE): Delete this after we've converted
everything to GN.
GYP_IS_ALREADY_GONE I hope?

[kylechar, 2016-11-14 21:49:00]

https://codereview.chromium.org/2493063003/diff/20001/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (right):

https://codereview.chromium.org/2493063003/diff/20001/ui/gl/BUILD.gn#newcode414
ui/gl/BUILD.gn:414: # TODO(GYP_GONE): Delete this after we've converted
everything to GN.
On 2016/11/14 21:19:35, sadrul wrote:
> GYP_IS_ALREADY_GONE I hope?

Yes, GYP is gone but GN still needs the extra target. Not totally sure why it
does, but all of the <test>_run targets still have this comment. Like 
https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?q=%22TODO(GYP_GONE)...
for example.

This way gl_unittests_ozonex_run gets cleaned up with the rest of them, should
https://cs.chromium.org/chromium/src/testing/test.gni?q=%22TODO(GYP_GONE)%22&...
change and not require <test>_run anymore?

[kylechar, 2016-11-14 21:49:04]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 21:49:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:00:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 23:00:09]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-11-15 00:35:34]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-11-15 00:35:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2493063003/#ps40001
(title: "Update comment.")

[commit-bot: I haz the power, 2016-11-15 00:36:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 00:56:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-15 01:04:49]

Description was changed from

==========
Run gl_unittests with Ozone X11.

Add a new test target gl_unittests_ozonex that runs with
--ozone-platform=x11. The Ozone CrOS bot will now run gl_unittests with
both Ozone headless and Ozone X11.

The test requires an X server to be running on the bot. The mb.py script
is modified to look for GN arg use_ozone=true and runtime flag
--ozone-platform=x11. In this case, it runs the test using xvfb.

BUG=664570
==========

to

==========
Run gl_unittests with Ozone X11.

Add a new test target gl_unittests_ozonex that runs with
--ozone-platform=x11. The Ozone CrOS bot will now run gl_unittests with
both Ozone headless and Ozone X11.

The test requires an X server to be running on the bot. The mb.py script
is modified to look for GN arg use_ozone=true and runtime flag
--ozone-platform=x11. In this case, it runs the test using xvfb.

BUG=664570

Committed: https://crrev.com/7895a178293de777611dd91255b9b90934f1a5df
Cr-Commit-Position: refs/heads/master@{#432038}
==========

[commit-bot: I haz the power, 2016-11-15 01:04:50]

Patchset 3 (id:??) landed as
https://crrev.com/7895a178293de777611dd91255b9b90934f1a5df
Cr-Commit-Position: refs/heads/master@{#432038}

[tandrii(chromium), 2016-11-16 15:15:46]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2506013002/ by tandrii@chromium.org.

The reason for reverting is: Likely caused error in isolate steps in
http://crbug.com/665895:

/b/c/b/linux_chromeos/src/out/Release/xdisplaycheck: no such file or directory
.