Reenable idle suspension of media elements on Windows.

Reenable idle suspension of media elements on Windows.

Use GLImages to hold references from the DXVA picture buffer to the
EGLStream or EGLSurface. This allows their contents to outlive the video
decoder.

BUG=663983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d
Cr-Commit-Position: refs/heads/master@{#432101}

[jbauman, 2016-11-11 05:04:50]

Description was changed from

==========
Reenable idle suspension of media elements on Windows.

Use GLImages to hold references to DXVA picture buffer the EGLStream or
EGLSurface. This allows their contents to outlive the video decoder.

BUG=663983
==========

to

==========
Reenable idle suspension of media elements on Windows.

Use GLImages to hold references to DXVA picture buffer the EGLStream or
EGLSurface. This allows their contents to outlive the video decoder.

BUG=663983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2016-11-11 05:04:56]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 05:05:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 06:24:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 06:24:43]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[jbauman, 2016-11-11 21:04:39]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 21:05:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-11-11 21:56:39]

Description was changed from

==========
Reenable idle suspension of media elements on Windows.

Use GLImages to hold references to DXVA picture buffer the EGLStream or
EGLSurface. This allows their contents to outlive the video decoder.

BUG=663983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reenable idle suspension of media elements on Windows.

Use GLImages to hold references from the DXVA picture buffer to the
EGLStream or EGLSurface. This allows their contents to outlive the video
decoder.

BUG=663983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2016-11-11 22:46:01]

jbauman@chromium.org changed reviewers:
+ sandersd@chromium.org

[DaleCurtis, 2016-11-11 23:16:15]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-11-11 23:16:16]

https://codereview.chromium.org/2495753002/diff/20001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2495753002/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:1764: #if !defined(OS_WIN) &&
!defined(OS_ANDROID) && !defined(OS_CHROMEOS) && \
That's everything now :)

[jbauman, 2016-11-11 23:17:15]

https://codereview.chromium.org/2495753002/diff/20001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2495753002/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:1764: #if !defined(OS_WIN) &&
!defined(OS_ANDROID) && !defined(OS_CHROMEOS) && \
On 2016/11/11 23:16:16, DaleCurtis wrote:
> That's everything now :)

Ok, I wasn't sure if Chromecast was included here or not.

[DaleCurtis, 2016-11-11 23:34:53]

https://codereview.chromium.org/2495753002/diff/20001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2495753002/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:1764: #if !defined(OS_WIN) &&
!defined(OS_ANDROID) && !defined(OS_CHROMEOS) && \
On 2016/11/11 at 23:17:15, jbauman wrote:
> On 2016/11/11 23:16:16, DaleCurtis wrote:
> > That's everything now :)
> 
> Ok, I wasn't sure if Chromecast was included here or not.

Ah, you're right they're still using this workaround under OS_LINUX, so you
could at least change this to just say OS_LINUX for Chromecast. :/

[jbauman, 2016-11-11 23:45:03]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 23:45:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 02:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 02:32:30]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[sandersd (OOO until July 31), 2016-11-14 19:16:22]

https://codereview.chromium.org/2495753002/diff/40001/media/gpu/dxva_video_de...
File media/gpu/dxva_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2495753002/diff/40001/media/gpu/dxva_video_de...
media/gpu/dxva_video_decode_accelerator_win.cc:888: "Number of service and
client ids do not match", PLATFORM_FAILURE, );
Is this still correct for the vda unittest? At one point it was using the same
IDs for both, but there was a proposed CL to only send one of the lists. I don't
know what the end result was.

https://codereview.chromium.org/2495753002/diff/40001/media/gpu/dxva_video_de...
media/gpu/dxva_video_decode_accelerator_win.cc:898:
buffers[buffer_index].service_texture_ids()[i],
The second parameter should be the texture target. I'm not sure what it should
be for these, but it's either GL_TEXTURE_EXTERNEL_OES or GL_TEXTURE_2D.

[jbauman, 2016-11-14 23:24:16]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 23:25:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-11-15 01:27:46]

PTAL.

On 2016/11/14 19:16:22, sandersd wrote:
>
https://codereview.chromium.org/2495753002/diff/40001/media/gpu/dxva_video_de...
> File media/gpu/dxva_video_decode_accelerator_win.cc (right):
> 
>
https://codereview.chromium.org/2495753002/diff/40001/media/gpu/dxva_video_de...
> media/gpu/dxva_video_decode_accelerator_win.cc:888: "Number of service and
> client ids do not match", PLATFORM_FAILURE, );
> Is this still correct for the vda unittest? At one point it was using the same
> IDs for both, but there was a proposed CL to only send one of the lists. I
don't
> know what the end result was.

I remvoed this in this patch.
> 
>
https://codereview.chromium.org/2495753002/diff/40001/media/gpu/dxva_video_de...
> media/gpu/dxva_video_decode_accelerator_win.cc:898:
> buffers[buffer_index].service_texture_ids()[i],
> The second parameter should be the texture target. I'm not sure what it should
> be for these, but it's either GL_TEXTURE_EXTERNEL_OES or GL_TEXTURE_2D.

Oops, fixed.

[commit-bot: I haz the power, 2016-11-15 01:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 01:34:55]

Dry run: This issue passed the CQ dry run.

[sandersd (OOO until July 31), 2016-11-15 01:40:06]

lgtm

https://codereview.chromium.org/2495753002/diff/60001/media/gpu/dxva_video_de...
File media/gpu/dxva_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2495753002/diff/60001/media/gpu/dxva_video_de...
media/gpu/dxva_video_decode_accelerator_win.cc:891: for (uint32_t client_id :
buffers[buffer_index].client_texture_ids()) {
For people like myself that rarely work with BOUND images, this structure is
surprising (it looks like different textures will end up with the same
contents). Probably worth a comment.

[DaleCurtis, 2016-11-15 01:42:17]

dalecurtis@chromium.org changed reviewers:
- dalecurtis@chromium.org

[jbauman, 2016-11-15 02:32:52]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-11-15 02:32:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2495753002/#ps80001
(title: "add comment")

[commit-bot: I haz the power, 2016-11-15 02:34:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 04:46:22]

Description was changed from

==========
Reenable idle suspension of media elements on Windows.

Use GLImages to hold references from the DXVA picture buffer to the
EGLStream or EGLSurface. This allows their contents to outlive the video
decoder.

BUG=663983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reenable idle suspension of media elements on Windows.

Use GLImages to hold references from the DXVA picture buffer to the
EGLStream or EGLSurface. This allows their contents to outlive the video
decoder.

BUG=663983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-15 04:46:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-15 04:50:51]

Description was changed from

==========
Reenable idle suspension of media elements on Windows.

Use GLImages to hold references from the DXVA picture buffer to the
EGLStream or EGLSurface. This allows their contents to outlive the video
decoder.

BUG=663983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reenable idle suspension of media elements on Windows.

Use GLImages to hold references from the DXVA picture buffer to the
EGLStream or EGLSurface. This allows their contents to outlive the video
decoder.

BUG=663983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d
Cr-Commit-Position: refs/heads/master@{#432101}
==========

[commit-bot: I haz the power, 2016-11-15 04:50:52]

Patchset 5 (id:??) landed as
https://crrev.com/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d
Cr-Commit-Position: refs/heads/master@{#432101}