Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2495723002: DevTools: [Sources] Make typing faster when search is open (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Sources] Make typing faster when search is open The old code was attempting to cache the mode via comparing regexes with ===. However, regexes are objects and thus could not be compared like this. This patch compares regexes properly. BUG=664324 Committed: https://crrev.com/90c635fa8c796d777dd03e173e0ceca3940f587f Cr-Commit-Position: refs/heads/master@{#431573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
einbinder
ptal
4 years, 1 month ago (2016-11-11 00:59:47 UTC) #2
lushnikov
lgtm
4 years, 1 month ago (2016-11-11 01:00:23 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2490273003 Patch 1). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-11 01:00:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495723002/1
4 years, 1 month ago (2016-11-11 16:25:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 16:30:39 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 16:32:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90c635fa8c796d777dd03e173e0ceca3940f587f
Cr-Commit-Position: refs/heads/master@{#431573}

Powered by Google App Engine
This is Rietveld 408576698