Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2490273003:
DevTools: [Sources] Speed up editor tab opening (Closed)
|
Created:
4 years, 1 month ago by einbinder Modified:
4 years, 1 month ago Reviewers:
lushnikov CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: [Sources] Speed up editor tab opening
This consolidates the resize event into a single CM operation.
BUG=664324
Committed: https://crrev.com/89a6c654ed501561d3646534dc6277e8b982d2cb
Cr-Commit-Position: refs/heads/master@{#431532}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 20 (11 generated)
einbinder@chromium.org changed reviewers: + lushnikov@chromium.org
ptal!
The CQ bit was checked by einbinder@chromium.org to run a CQ dry run
Description was changed from ========== DevTools: [Sources] Speed up editor tab opening This consolidates the resize event into a single CM operation. BUG=664324 ========== to ========== DevTools: [Sources] Speed up editor tab opening This cuts down the editor resize time from 110ms to 40ms in our tests. This patch consolidates the resize event into a single CM operation. BUG=664324 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by lushnikov@chromium.org
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: [Sources] Speed up editor tab opening This consolidates the resize event into a single CM operation. BUG=664324 ========== to ========== DevTools: [Sources] Speed up editor tab opening This consolidates the resize event into a single CM operation. BUG=664324 Committed: https://crrev.com/89a6c654ed501561d3646534dc6277e8b982d2cb Cr-Commit-Position: refs/heads/master@{#431532} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/89a6c654ed501561d3646534dc6277e8b982d2cb Cr-Commit-Position: refs/heads/master@{#431532} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
