Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2495563002: [runtime] Treat empty property cells properly when doing Object.freeze() on a global object. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Treat empty property cells properly when doing Object.freeze() on a global object. BUG=chromium:663750, chromium:664123 Committed: https://crrev.com/45b9f15f4489a93896d6d8131058607ee85bf4a4 Cr-Commit-Position: refs/heads/master@{#40902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-663750.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-10 15:16:50 UTC) #4
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-10 15:58:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495563002/1
4 years, 1 month ago (2016-11-10 15:58:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 16:00:52 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45b9f15f4489a93896d6d8131058607ee85bf4a4
Cr-Commit-Position: refs/heads/master@{#40902}

Powered by Google App Engine
This is Rietveld 408576698