Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: src/objects.cc

Issue 2495563002: [runtime] Treat empty property cells properly when doing Object.freeze() on a global object. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-663750.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index ec870c70b52f512329eccad0d0428d918f797118..89c40c1022b9046b3e31692270cdb01d414cd7fd 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -8004,6 +8004,7 @@ void DictionaryDetailsAtPut<GlobalDictionary>(
Object* value = dictionary->ValueAt(entry);
DCHECK(value->IsPropertyCell());
value = PropertyCell::cast(value)->value();
+ if (value->IsTheHole(isolate)) return;
PropertyCell::PrepareForValue(dictionary, entry, handle(value, isolate),
details);
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-663750.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698