[Controversial] Remove the random emoji from "Tree is open" messages.

[Controversial] Remove the random emoji from "Tree is open" messages.

Why?  It looks unprofessional.  These strings are displayed in some pretty
prominent places now (buildbot console, gerrit) and the long ones are just
noise that clutter the UI without adding anything useful.

They are confusing to new people joining the project ("Why does the website
say ☆.｡.:*･ﾟ☆.｡.:*･ﾟ☆祝☆ﾟ･*:.｡.☆ﾟ･*:.｡.☆?  Is my browser broken?").

Users who see these messages are trying to land CLs.  They're probably angry
that their tests are flaky.  Infra's tools shouldn't be distracting them by
telling them good luck in Kazakh, they should be getting out of the way so
the user can get work done.

BUG=

[dsansome, 2016-11-10 09:40:57]

dsansome@chromium.org changed reviewers:
+ agable@chromium.org, benhenry@google.com, philwright@google.com,
stip@chromium.org

[dsansome, 2016-11-10 09:40:58]

¯\_(ツ)_/¯

[benhenry, 2016-11-10 16:34:04]

On 2016/11/10 09:40:58, dsansome wrote:
> ¯\_(ツ)_/¯

Bugs, not shrugs...

But thank you for doing this. There's a mix of culture that needs to be had on
our products, but I agree that with some of these user facing things, it goes a
bit far. I think we have enough fun with our naming of services...

LGTM

[ghost stip (do not use), 2016-11-10 16:41:36]

stip@chromium.org changed reviewers:
+ danakj@chromium.org, jochen@chromium.org, thakis@chromium.org

[ghost stip (do not use), 2016-11-10 16:41:36]

The history behind the emoji is that engineers were doing this anyway. Here's an
example from two weeks ago (these are humans updating the status, not the bot)
http://imgur.com/a/jEu5s. When I originally wrote gatekeeper auto-open, things
looked very sterile without the randomized human touch.

The longer ones were taken from statuses humans wrote (the engineers in the
Tokyo office are particularly creative).

We've also received several contributions from engineers adding to the list:
https://chromium.googlesource.com/chromium/tools/build/+log/master/scripts/sl...

The 'good luck' in many languages was something I added as an homage to the
breadth of the languages on the team. My goal was to a) test unicode rendering
codepaths, b) get people interested in other languages, and c) make engineers
who speak an often-neglected language smile. I'm not sure if I've achieved the
last goal, but I've certainly done the first two.

I suggest we bring this to chromium-dev, as chromium sheriffs and engineers have
the biggest stake in this. Alternately, we could also remove this from just
infra-status, although I suspect there will be similar gnashing of teeth.

[aboxhall, 2016-11-10 16:56:31]

not lgtm

The buildbot messages are delightful and welcoming and a reminder that we're not
a monocultural team. I especially take exception to "unprofessional" here - they
are written by utmost professionals who care a lot about the infrastructure that
they run on, so what precisely is unprofessional about them?

If people are confused by them, it's a great teachable moment to discuss their
history and the entire line of reasoning stip@ gave above.

Perhaps that comment needs to go on a wiki page that we could discreetly link to
somewhere on http://chromium-status.appspot.com/, if there is genuine confusion.

[aboxhall, 2016-11-10 16:56:32]

not lgtm

The buildbot messages are delightful and welcoming and a reminder that we're not
a monocultural team. I especially take exception to "unprofessional" here - they
are written by utmost professionals who care a lot about the infrastructure that
they run on, so what precisely is unprofessional about them?

If people are confused by them, it's a great teachable moment to discuss their
history and the entire line of reasoning stip@ gave above.

Perhaps that comment needs to go on a wiki page that we could discreetly link to
somewhere on http://chromium-status.appspot.com/, if there is genuine confusion.

[jochen (gone - plz use gerrit), 2016-11-10 18:19:16]

jochen@chromium.org changed reviewers:
+ aboxhall@chromium.org

[jochen (gone - plz use gerrit), 2016-11-10 18:19:17]

It's an interesting point of view of chromium developers as users of the
infrastructure, which implies that these are indeed user facing messages.

However, I also think that the argument that these are part of our shared
culture is a very valid one - after all, many of the messages were added by
users, and if I'm not mistaken, at least one of them asks for new additions.

Maybe we can make this information more readily available, e.g., a link on the
*-status.appspot.com pages to an explainer page?

[iannucci1, 2016-11-10 20:06:18]

fwiw, not lgtm to me too. Unless you have data from users that they actually
don't like these (they liked them when they were added initially), I don't think
this change is warranted.

[danakj, 2016-11-10 21:01:19]

On 2016/11/10 16:56:31, aboxhall wrote:
> not lgtm
> 
> The buildbot messages are delightful and welcoming and a reminder that we're
not
> a monocultural team. I especially take exception to "unprofessional" here -
they
> are written by utmost professionals who care a lot about the infrastructure
that
> they run on, so what precisely is unprofessional about them?
> 
> If people are confused by them, it's a great teachable moment to discuss their
> history and the entire line of reasoning stip@ gave above.
> 
> Perhaps that comment needs to go on a wiki page that we could discreetly link
to
> somewhere on http://chromium-status.appspot.com/, if there is genuine
confusion.

<3

[ghost stip (do not use), 2016-11-10 21:18:54]

After some discussion here and on chromium-dev, I've filed
https://bugs.chromium.org/p/gerrit/issues/detail?id=4914 to add an explanation
link on gerrit for what the tree status means. I'll file subsequent ones for
buildbot as well.

[chromium-reviews, 2016-11-14 00:42:21]

for the record, I'm +1 to removing the random emoji. I find them confusing
and distracting.

On 11 November 2016 at 08:18, <stip@chromium.org> wrote:

> After some discussion here and on chromium-dev, I've filed
> https://bugs.chromium.org/p/gerrit/issues/detail?id=4914 to add an
> explanation
> link on gerrit for what the tree status means. I'll file subsequent ones
> for
> buildbot as well.
>
> https://codereview.chromium.org/2495493002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dsansome, 2016-11-16 02:55:41]

Description was changed from

==========
[Controversial] Remove the random emoji from "Tree is open" messages.

Why?  It looks unprofessional.  These strings are displayed in some pretty
prominent places now (buildbot console, gerrit) and the long ones are just
noise that clutter the UI without adding anything useful.

They are confusing to new people joining the project ("Why does the website
say ☆.｡.:*･ﾟ☆.｡.:*･ﾟ☆祝☆ﾟ･*:.｡.☆ﾟ･*:.｡.☆?  Is my browser broken?").

Users who see these messages are trying to land CLs.  They're probably angry
that their tests are flaky.  Infra's tools shouldn't be distracting them by
telling them good luck in Kazakh, they should be getting out of the way so
the user can get work done.

BUG=
==========

to

==========
[Controversial] Remove the random emoji from "Tree is open" messages.

Why?  It looks unprofessional.  These strings are displayed in some pretty
prominent places now (buildbot console, gerrit) and the long ones are just
noise that clutter the UI without adding anything useful.

They are confusing to new people joining the project ("Why does the website
say ☆.｡.:*･ﾟ☆.｡.:*･ﾟ☆祝☆ﾟ･*:.｡.☆ﾟ･*:.｡.☆?  Is my browser broken?").

Users who see these messages are trying to land CLs.  They're probably angry
that their tests are flaky.  Infra's tools shouldn't be distracting them by
telling them good luck in Kazakh, they should be getting out of the way so
the user can get work done.

BUG=
==========