Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: scripts/slave/recipe_modules/gatekeeper/api.py

Issue 2495493002: [Controversial] Remove the random emoji from "Tree is open" messages. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine import recipe_api 5 from recipe_engine import recipe_api
6 6
7 7
8 class Gatekeeper(recipe_api.RecipeApi): 8 class Gatekeeper(recipe_api.RecipeApi):
9 """Module for Gatekeeper NG.""" 9 """Module for Gatekeeper NG."""
10 def __call__(self, gatekeeper_json, gatekeeper_trees_json): 10 def __call__(self, gatekeeper_json, gatekeeper_trees_json):
11 config = self.m.json.read( 11 config = self.m.json.read(
12 'reading %s' % self.m.path.basename(gatekeeper_trees_json), 12 'reading %s' % self.m.path.basename(gatekeeper_trees_json),
13 gatekeeper_trees_json, 13 gatekeeper_trees_json,
14 ).json.output 14 ).json.output
15 15
16 for tree_name, tree_args in config.iteritems(): 16 for tree_name, tree_args in config.iteritems():
17 # TODO(martiniss): create a creds recipe module to make a nice path 17 # TODO(martiniss): create a creds recipe module to make a nice path
18 # reference to /creds 18 # reference to /creds
19 args = [ 19 args = [
20 '-v', '--json', gatekeeper_json, '--email-app-secret-file', 20 '-v', '--json', gatekeeper_json, '--email-app-secret-file',
21 '/creds/gatekeeper/mailer_password' 21 '/creds/gatekeeper/mailer_password',
22 '--emoji', 'None',
22 ] 23 ]
23 24
24 if tree_args.get('status-url'): 25 if tree_args.get('status-url'):
25 args.extend(['--status-url', tree_args['status-url']]) 26 args.extend(['--status-url', tree_args['status-url']])
26 if tree_args.get('sheriff-url'): 27 if tree_args.get('sheriff-url'):
27 args.extend(['--sheriff-url', tree_args['sheriff-url']]) 28 args.extend(['--sheriff-url', tree_args['sheriff-url']])
28 if tree_args.get('set-status'): 29 if tree_args.get('set-status'):
29 args.append('--set-status') 30 args.append('--set-status')
30 if tree_args.get('open-tree'): 31 if tree_args.get('open-tree'):
31 args.append('--open-tree') 32 args.append('--open-tree')
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 args.extend(tree_args['masters']) 66 args.extend(tree_args['masters'])
66 67
67 try: 68 try:
68 self.m.python( 69 self.m.python(
69 'gatekeeper: %s' % str(tree_name), 70 'gatekeeper: %s' % str(tree_name),
70 self.package_repo_resource('scripts', 'slave', 'gatekeeper_ng.py'), 71 self.package_repo_resource('scripts', 'slave', 'gatekeeper_ng.py'),
71 args, 72 args,
72 ) 73 )
73 except self.m.step.StepFailure: 74 except self.m.step.StepFailure:
74 pass 75 pass
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698