Enables passing initial properties to top level window creation

Enables passing initial properties to top level window creation

This is needed for the wm to decide where to place the window.

As part of this I'm making it so some WindowTreeHostPlatform
constructors don't call CreateCompositor(). This way properties can be
set on the window before Init() is called. This is important as at the
time of Init() the server side window is created.

BUG=660994
TEST=covered by tests
R=sadrul@chromium.org

Committed: https://crrev.com/4663012883fe100b31fab84165ffca73a14d09dc
Cr-Commit-Position: refs/heads/master@{#432578}

[sky, 2016-11-16 03:38:52]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 03:39:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-11-16 04:23:57]

sky@chromium.org changed reviewers:
+ dtrainor@chromium.org

[sky, 2016-11-16 04:23:58]

+dtrainor for blimp

[David Trainor- moved to gerrit, 2016-11-16 04:26:39]

blimp/ lgtm!

[commit-bot: I haz the power, 2016-11-16 04:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 04:38:35]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-11-16 18:02:08]

lgtm

https://codereview.chromium.org/2495423005/diff/20001/ui/aura/window_tree_hos...
File ui/aura/window_tree_host_platform.h (right):

https://codereview.chromium.org/2495423005/diff/20001/ui/aura/window_tree_hos...
ui/aura/window_tree_host_platform.h:47: // CreateCompositor() at the appropriate
time.
Is this change because the creation of the compositor depends on some of the
attributes on the mus window?

[sky, 2016-11-16 18:45:49]

https://codereview.chromium.org/2495423005/diff/20001/ui/aura/window_tree_hos...
File ui/aura/window_tree_host_platform.h (right):

https://codereview.chromium.org/2495423005/diff/20001/ui/aura/window_tree_hos...
ui/aura/window_tree_host_platform.h:47: // CreateCompositor() at the appropriate
time.
On 2016/11/16 18:02:08, sadrul wrote:
> Is this change because the creation of the compositor depends on some of the
> attributes on the mus window?

CreateCompositor() calls window->Init(). window->Init(), for aura-mus, is the
time at which the the window server is asked to create the window. When the
server window is created properties may be provided to help influence initial
configuration of the serverwindow. By delaying the call to CreateCompositor
WindowTreeHostMus now has the ability to set properties on the aura::Window
before Init() is called so that initial properties make there way to
ServerWindow.

[sky, 2016-11-16 18:45:54]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-11-16 18:46:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 19:06:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 19:22:09]

Description was changed from

==========
Enables passing initial properties to top level window creation

This is needed for the wm to decide where to place the window.

As part of this I'm making it so some WindowTreeHostPlatform
constructors don't call CreateCompositor(). This way properties can be
set on the window before Init() is called. This is important as at the
time of Init() the server side window is created.

BUG=660994
TEST=covered by tests
R=sadrul@chromium.org
==========

to

==========
Enables passing initial properties to top level window creation

This is needed for the wm to decide where to place the window.

As part of this I'm making it so some WindowTreeHostPlatform
constructors don't call CreateCompositor(). This way properties can be
set on the window before Init() is called. This is important as at the
time of Init() the server side window is created.

BUG=660994
TEST=covered by tests
R=sadrul@chromium.org

Committed: https://crrev.com/4663012883fe100b31fab84165ffca73a14d09dc
Cr-Commit-Position: refs/heads/master@{#432578}
==========

[commit-bot: I haz the power, 2016-11-16 19:22:10]

Patchset 2 (id:??) landed as
https://crrev.com/4663012883fe100b31fab84165ffca73a14d09dc
Cr-Commit-Position: refs/heads/master@{#432578}