Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2495423003: Revert of Suppress findbugs warnings on Chromium for syncronized methods (Closed)

Created:
4 years, 1 month ago by Yusuf
Modified:
4 years, 1 month ago
Reviewers:
Ian Wen, Benoit L
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Suppress findbugs warnings on Chromium for syncronized methods (patchset #1 id:1 of https://codereview.chromium.org/2501063002/ ) Reason for revert: Broke compile Original issue's description: > Suppress findbugs warnings on Chromium for syncronized methods > > Have to suppress warnings with annotation to roll DEPS and land on > Chromium. > > Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/6831edaa4f079d2d033d714c9a4df4b3e16feb97 TBR=ianwen@chromium.org,lizeb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/e2b6730dad438de70d88b6ae5d33aa0995ba77d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M customtabs/src/android/support/customtabs/CustomTabsCallback.java View 3 chunks +0 lines, -4 lines 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsClient.java View 3 chunks +0 lines, -4 lines 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsSession.java View 2 chunks +0 lines, -3 lines 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsSessionToken.java View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Yusuf
Created Revert of Suppress findbugs warnings on Chromium for syncronized methods
4 years, 1 month ago (2016-11-14 20:26:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495423003/1
4 years, 1 month ago (2016-11-14 20:26:44 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 20:26:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/GoogleChrome/custom-tabs-client/commit/e2b6730dad438de70d8...

Powered by Google App Engine
This is Rietveld 408576698