Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: src/compiler/liveness-analyzer.cc

Issue 2495413003: [turbofan] Do not use the state value cache when building the tree (Closed)
Patch Set: Re-upload Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/liveness-analyzer.cc
diff --git a/src/compiler/liveness-analyzer.cc b/src/compiler/liveness-analyzer.cc
index 5a60d50e9086aa67ff2688a30147c77d1eea4068..0cf13332f4e8240de629eb7a13df71f908a60e21 100644
--- a/src/compiler/liveness-analyzer.cc
+++ b/src/compiler/liveness-analyzer.cc
@@ -160,13 +160,20 @@ void NonLiveFrameStateSlotReplacer::ClearNonLiveFrameStateSlots(
Node* NonLiveFrameStateSlotReplacer::ClearNonLiveStateValues(
Node* values, BitVector* liveness) {
DCHECK(inputs_buffer_.empty());
- for (StateValuesAccess::TypedNode node : StateValuesAccess(values)) {
+
+ int var = 0;
+ for (Node* value_node : values->inputs()) {
+ // Make sure this isn't a state value tree
+ DCHECK(value_node->opcode() != IrOpcode::kStateValues);
+
// Index of the next variable is its furure index in the inputs buffer,
// i.e., the buffer's size.
- int var = static_cast<int>(inputs_buffer_.size());
bool live = liveness->Contains(var) || permanently_live_.Contains(var);
- inputs_buffer_.push_back(live ? node.node : replacement_node_);
+ inputs_buffer_.push_back(live ? value_node : replacement_node_);
+
+ var++;
}
+
Node* result = state_values_cache()->GetNodeForValues(
inputs_buffer_.empty() ? nullptr : &(inputs_buffer_.front()),
inputs_buffer_.size());
« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698