[turbofan] Do not use the state value cache when building the tree

src/compiler/liveness-analyzer.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/base/adapters.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/liveness-analyzer.h"
 #include "src/compiler/node.h"
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/state-values-utils.h"
@@ skipping 142 matching lines @@
           state_values_cache()->GetNodeForValues(&replacement_node_, 1);
       frame_state->ReplaceInput(2, new_value);
     }
   }
 }
 
 
 Node* NonLiveFrameStateSlotReplacer::ClearNonLiveStateValues(
     Node* values, BitVector* liveness) {
   DCHECK(inputs_buffer_.empty());
-  for (StateValuesAccess::TypedNode node : StateValuesAccess(values)) {
+
+  int var = 0;
+  for (Node* value_node : values->inputs()) {
+    // Make sure this isn't a state value tree
+    DCHECK(value_node->opcode() != IrOpcode::kStateValues);
+
     // Index of the next variable is its furure index in the inputs buffer,
     // i.e., the buffer's size.
-    int var = static_cast<int>(inputs_buffer_.size());
     bool live = liveness->Contains(var) || permanently_live_.Contains(var);
-    inputs_buffer_.push_back(live ? node.node : replacement_node_);
+    inputs_buffer_.push_back(live ? value_node : replacement_node_);
+
+    var++;
   }
+
   Node* result = state_values_cache()->GetNodeForValues(
       inputs_buffer_.empty() ? nullptr : &(inputs_buffer_.front()),
       inputs_buffer_.size());
   inputs_buffer_.clear();
   return result;
 }
 
 
 void LivenessAnalyzerBlock::Print(std::ostream& os) {
   os << "Block " << id();
@@ skipping 37 matching lines @@
     for (int i = 0; i < live_.length(); i++) {
       os << (live_.Contains(i) ? "L" : ".");
     }
     os << std::endl;
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8