Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2495413003: [turbofan] Do not use the state value cache when building the tree (Closed)

Created:
4 years, 1 month ago by Leszek Swirski
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Do not use the state value cache when building the tree Since the liveness analysis's non-live value clearing rebuilds the state value trees, we don't need to be smart when creating state values in the initial graph building. This simplifies both the building and the iteration over the state values by the liveness analyzer. Committed: https://crrev.com/4a660091ee284630c2d315f8a0e736675bec8855 Cr-Commit-Position: refs/heads/master@{#40996}

Patch Set 1 #

Patch Set 2 : Re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -22 lines) Patch
M src/compiler/ast-graph-builder.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 chunks +1 line, -8 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download
M src/compiler/liveness-analyzer.cc View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Leszek Swirski
As discussed f2f, I see ~2% improvements on Box2D and Typescript with this.
4 years, 1 month ago (2016-11-15 13:15:39 UTC) #4
Jarin
On 2016/11/15 13:15:39, Leszek Swirski wrote: > As discussed f2f, I see ~2% improvements on ...
4 years, 1 month ago (2016-11-15 13:25:06 UTC) #5
Leszek Swirski
On 2016/11/15 13:25:06, Jarin wrote: > On 2016/11/15 13:15:39, Leszek Swirski wrote: > > As ...
4 years, 1 month ago (2016-11-15 13:55:58 UTC) #8
Jarin
lgtm. Thanks!
4 years, 1 month ago (2016-11-15 14:06:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495413003/20001
4 years, 1 month ago (2016-11-15 14:08:36 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 14:22:55 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:34:16 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a660091ee284630c2d315f8a0e736675bec8855
Cr-Commit-Position: refs/heads/master@{#40996}

Powered by Google App Engine
This is Rietveld 408576698