Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 249533002: Fix build/android/enable_asserts.py. (Closed)

Created:
6 years, 8 months ago by ppi
Modified:
6 years, 8 months ago
Reviewers:
craigdh, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Fix build/android/enable_asserts.py. The script seems to have been broken in https://codereview.chromium.org/221823011 (missing device serial when creating DeviceUtils). This fixes the script by iterating over all connected devices. BUG=267773 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265770

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a TODO for optional serial number argument. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M build/android/enable_asserts.py View 1 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ppi
Please take a look.
6 years, 8 months ago (2014-04-23 15:22:20 UTC) #1
jbudorick
lgtm https://codereview.chromium.org/249533002/diff/1/build/android/enable_asserts.py File build/android/enable_asserts.py (right): https://codereview.chromium.org/249533002/diff/1/build/android/enable_asserts.py#newcode26 build/android/enable_asserts.py:26: for device in [device_utils.DeviceUtils(serial) for serial in devices]: ...
6 years, 8 months ago (2014-04-23 15:29:57 UTC) #2
jbudorick
On 2014/04/23 15:29:57, jbudorick wrote: > lgtm I should mention that my lgtms don't count ...
6 years, 8 months ago (2014-04-23 15:30:45 UTC) #3
craigdh
rubberstamp lgtm based on john's review
6 years, 8 months ago (2014-04-23 15:30:49 UTC) #4
ppi
Thanks! Added a TODO for the optional serial number argument as suggested.
6 years, 8 months ago (2014-04-23 15:33:59 UTC) #5
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 8 months ago (2014-04-23 15:34:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/249533002/20001
6 years, 8 months ago (2014-04-23 15:39:33 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 23:28:01 UTC) #8
Message was sent while issue was closed.
Change committed as 265770

Powered by Google App Engine
This is Rietveld 408576698