Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 221823011: [Android] Change object types from AndroidCommands to DeviceUtils in build/android/. (Closed)

Created:
6 years, 8 months ago by jbudorick
Modified:
6 years, 8 months ago
Reviewers:
craigdh, bulach, frankf
CC:
chromium-reviews, bulach+watch_chromium.org, yfriedman+watch_chromium.org, timurrrr+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Change object types from AndroidCommands to DeviceUtils in build/android/. BUG=267773 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263055

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address Frank's comments. #

Total comments: 7

Patch Set 3 : rebase + address Craig's comments #

Patch Set 4 : rebase #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+629 lines, -487 lines) Patch
M build/android/adb_install_apk.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M build/android/adb_kill_content_shell View 1 chunk +1 line, -1 line 0 comments Download
M build/android/adb_profile_chrome.py View 1 11 chunks +32 lines, -23 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 2 chunks +5 lines, -4 lines 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 1 6 chunks +17 lines, -18 lines 0 comments Download
M build/android/buildbot/bb_device_steps.py View 1 4 chunks +4 lines, -4 lines 0 comments Download
M build/android/enable_asserts.py View 2 chunks +4 lines, -4 lines 0 comments Download
M build/android/gyp/util/build_device.py View 1 3 chunks +11 lines, -10 lines 0 comments Download
M build/android/host_heartbeat.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M build/android/provision_devices.py View 1 7 chunks +27 lines, -24 lines 0 comments Download
M build/android/pylib/android_commands.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/base/base_test_runner.py View 9 chunks +17 lines, -16 lines 0 comments Download
M build/android/pylib/base/test_dispatcher.py View 1 6 chunks +12 lines, -10 lines 0 comments Download
M build/android/pylib/chrome_test_server_spawner.py View 7 chunks +11 lines, -11 lines 0 comments Download
M build/android/pylib/constants.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/content_settings.py View 1 2 4 chunks +11 lines, -10 lines 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 1 2 chunks +5 lines, -1 line 0 comments Download
M build/android/pylib/device/adb_wrapper_test.py View 1 chunk +1 line, -1 line 0 comments Download
A build/android/pylib/device/device_utils.py View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M build/android/pylib/device_settings.py View 3 chunks +7 lines, -5 lines 0 comments Download
M build/android/pylib/flag_changer.py View 3 chunks +24 lines, -11 lines 0 comments Download
M build/android/pylib/forwarder.py View 8 chunks +40 lines, -28 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/gtest/test_package.py View 1 chunk +11 lines, -11 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 5 chunks +31 lines, -30 lines 0 comments Download
M build/android/pylib/gtest/test_package_exe.py View 7 chunks +15 lines, -15 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 2 3 4 6 chunks +14 lines, -14 lines 0 comments Download
M build/android/pylib/host_driven/test_case.py View 4 chunks +5 lines, -5 lines 0 comments Download
M build/android/pylib/host_driven/test_runner.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/instrumentation/test_package.py View 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 2 3 4 15 chunks +41 lines, -33 lines 0 comments Download
M build/android/pylib/linker/test_case.py View 9 chunks +23 lines, -23 lines 0 comments Download
M build/android/pylib/monkey/test_runner.py View 3 chunks +8 lines, -9 lines 0 comments Download
M build/android/pylib/perf/cache_control.py View 1 chunk +10 lines, -4 lines 0 comments Download
M build/android/pylib/perf/perf_control.py View 4 chunks +18 lines, -10 lines 0 comments Download
M build/android/pylib/perf/surface_stats_collector.py View 6 chunks +12 lines, -6 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M build/android/pylib/perf/thermal_throttle.py View 7 chunks +26 lines, -17 lines 0 comments Download
M build/android/pylib/ports.py View 2 chunks +4 lines, -3 lines 0 comments Download
M build/android/pylib/screenshot.py View 8 chunks +27 lines, -16 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 1 2 7 chunks +8 lines, -7 lines 0 comments Download
M build/android/pylib/utils/test_environment.py View 1 2 chunks +8 lines, -7 lines 0 comments Download
M build/android/pylib/valgrind_tools.py View 8 chunks +35 lines, -35 lines 0 comments Download
M build/android/screenshot.py View 1 2 chunks +8 lines, -8 lines 0 comments Download
M build/android/surface_stats.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/tombstones.py View 1 5 chunks +27 lines, -21 lines 0 comments Download
M build/android/update_verification.py View 1 8 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jbudorick
6 years, 8 months ago (2014-04-03 01:11:56 UTC) #1
frankf
https://codereview.chromium.org/221823011/diff/1/build/android/pylib/device/device_filter.py File build/android/pylib/device/device_filter.py (right): https://codereview.chromium.org/221823011/diff/1/build/android/pylib/device/device_filter.py#newcode5 build/android/pylib/device/device_filter.py:5: from pylib.device import device_blacklist This module is not very ...
6 years, 8 months ago (2014-04-03 02:13:50 UTC) #2
jbudorick
Per Frank's comment, this CL no longer contains: - device_filter.py - new_line_normalizer.py - the switch ...
6 years, 8 months ago (2014-04-03 17:46:25 UTC) #3
jbudorick
On 2014/04/03 17:46:25, jbudorick wrote: > Per Frank's comment, this CL no longer contains: > ...
6 years, 8 months ago (2014-04-08 22:17:48 UTC) #4
craigdh
https://codereview.chromium.org/221823011/diff/40001/build/android/adb_profile_chrome.py File build/android/adb_profile_chrome.py (right): https://codereview.chromium.org/221823011/diff/40001/build/android/adb_profile_chrome.py#newcode139 build/android/adb_profile_chrome.py:139: # TODO(jbudorick) can this be made work with DeviceUtils? ...
6 years, 8 months ago (2014-04-09 15:55:02 UTC) #5
jbudorick
https://codereview.chromium.org/221823011/diff/40001/build/android/adb_profile_chrome.py File build/android/adb_profile_chrome.py (right): https://codereview.chromium.org/221823011/diff/40001/build/android/adb_profile_chrome.py#newcode139 build/android/adb_profile_chrome.py:139: # TODO(jbudorick) can this be made work with DeviceUtils? ...
6 years, 8 months ago (2014-04-09 20:03:32 UTC) #6
craigdh
lgtm. Don't land this one on a Friday afternoon...
6 years, 8 months ago (2014-04-09 20:10:21 UTC) #7
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 8 months ago (2014-04-09 21:27:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/221823011/80001
6 years, 8 months ago (2014-04-09 21:28:42 UTC) #9
jbudorick
The CQ bit was unchecked by jbudorick@chromium.org
6 years, 8 months ago (2014-04-09 23:00:45 UTC) #10
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 8 months ago (2014-04-10 17:14:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/221823011/100001
6 years, 8 months ago (2014-04-10 17:23:19 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 19:37:32 UTC) #13
Message was sent while issue was closed. 
Change committed as 263055

Powered by Google App Engine
This is Rietveld 408576698