Add referrerpolicy to style and import

Add referrerpolicy to style and import

This CL adds referrerpolicy attribute support to `<link rel=style>` and
`<link rel=import>`.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/LukPJ86fcs8/RX_dsbUiCAAJ

BUG=595099
Committed: https://crrev.com/44793d655d87d2c0a5161b59adf3ead794b9663b
Cr-Commit-Position: refs/heads/master@{#441108}

[Yoav Weiss, 2016-11-14 14:35:30]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 14:35:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2016-11-14 14:51:27]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 14:51:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 15:59:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 15:59:06]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2016-11-14 16:04:27]

Description was changed from

==========
Add referrerpolicy to style and import

This CL adds referrerpolicy attribute support to `<link rel=style>` and
`<link rel=import>`, as well as slightly refactors link styles loading
logic.

BUG=595099
==========

to

==========
Add referrerpolicy to style and import

This CL adds referrerpolicy attribute support to `<link rel=style>` and
`<link rel=import>`.

BUG=595099
==========

[Yoav Weiss, 2017-01-02 15:10:18]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-01-02 15:10:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-01-02 15:13:42]

yoav@yoav.ws changed reviewers:
+ estark@chromium.org

[Yoav Weiss, 2017-01-02 15:13:43]

This (belatedly) adds the referrerpolicy attribute to link stylesheet and
imports. Can you please review? :)

[commit-bot: I haz the power, 2017-01-02 17:00:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-02 17:00:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yoav Weiss, 2017-01-03 08:26:34]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 08:26:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-01-03 08:28:12]

yoav@yoav.ws changed reviewers:
+ jochen@chromium.org

[Yoav Weiss, 2017-01-03 08:28:12]

Hey Jochen,

Since estark seems to be out this week, can you take a look?

Thanks :)
Yoav

[jochen (gone - plz use gerrit), 2017-01-03 08:41:49]

https://codereview.chromium.org/2495313002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/LinkResource.cpp (right):

https://codereview.chromium.org/2495313002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/LinkResource.cpp:73: if (referrerPolicy !=
ReferrerPolicyDefault) {
why this if() ?

[Yoav Weiss, 2017-01-03 09:03:48]

https://codereview.chromium.org/2495313002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/LinkResource.cpp (right):

https://codereview.chromium.org/2495313002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/LinkResource.cpp:73: if (referrerPolicy !=
ReferrerPolicyDefault) {
On 2017/01/03 08:41:49, jochen wrote:
> why this if() ?

I was basing that code on ImageLoader.cpp:304 which includes a similar
condition, and sets the referrer only if it was explicitly set by an attribute.
If that is not correct, we'd have to fix that in multiple locations.

[jochen (gone - plz use gerrit), 2017-01-03 09:15:17]

fair enough, lgtm

[Yoav Weiss, 2017-01-03 09:21:10]

Description was changed from

==========
Add referrerpolicy to style and import

This CL adds referrerpolicy attribute support to `<link rel=style>` and
`<link rel=import>`.

BUG=595099
==========

to

==========
Add referrerpolicy to style and import

This CL adds referrerpolicy attribute support to `<link rel=style>` and
`<link rel=import>`.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/LukPJ86fcs8/RX_dsbUi...

BUG=595099
==========

[commit-bot: I haz the power, 2017-01-03 10:53:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 10:53:27]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2017-01-03 11:03:24]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2017-01-03 11:03:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 11:07:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483441404673170,
"parent_rev": "9f587552a2c7aecab3a11abc3b1769b13fada0f5", "commit_rev":
"62c41b9b12c184bb3eb6da349eef84d340204c96"}

[commit-bot: I haz the power, 2017-01-03 11:07:55]

Description was changed from

==========
Add referrerpolicy to style and import

This CL adds referrerpolicy attribute support to `<link rel=style>` and
`<link rel=import>`.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/LukPJ86fcs8/RX_dsbUi...

BUG=595099
==========

to

==========
Add referrerpolicy to style and import

This CL adds referrerpolicy attribute support to `<link rel=style>` and
`<link rel=import>`.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/LukPJ86fcs8/RX_dsbUi...

BUG=595099

Review-Url: https://codereview.chromium.org/2495313002
==========

[commit-bot: I haz the power, 2017-01-03 11:07:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2017-01-03 11:10:42]

Description was changed from

==========
Add referrerpolicy to style and import

This CL adds referrerpolicy attribute support to `<link rel=style>` and
`<link rel=import>`.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/LukPJ86fcs8/RX_dsbUi...

BUG=595099

Review-Url: https://codereview.chromium.org/2495313002
==========

to

==========
Add referrerpolicy to style and import

This CL adds referrerpolicy attribute support to `<link rel=style>` and
`<link rel=import>`.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/LukPJ86fcs8/RX_dsbUi...

BUG=595099

Committed: https://crrev.com/44793d655d87d2c0a5161b59adf3ead794b9663b
Cr-Commit-Position: refs/heads/master@{#441108}
==========

[commit-bot: I haz the power, 2017-01-03 11:10:43]

Patchset 4 (id:??) landed as
https://crrev.com/44793d655d87d2c0a5161b59adf3ead794b9663b
Cr-Commit-Position: refs/heads/master@{#441108}