Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2495283002:
PS - Updated UI strings used during login in Public Sessions (Closed)
|
Created:
4 years, 1 month ago by Ivan Šandrk Modified:
4 years, 1 month ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPS - Updated UI strings used during login in Public Sessions
BUG=664951
Committed: https://crrev.com/7946fd64850d151fdb8fa449b131860c3c6ca878
Cr-Commit-Position: refs/heads/master@{#431988}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Nit oxford comma #Patch Set 3 : Added 'Learn more' string #Patch Set 4 : Updated a string so it sounds more serious #Patch Set 5 : Added a missing fullstop #Messages
Total messages: 19 (10 generated)
isandrk@chromium.org changed reviewers: + atwilson@chromium.org, sduraisamy@google.com
Hey guys, please take a look!
lgtm https://codereview.chromium.org/2495283002/diff/1/chrome/app/chromeos_strings... File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2495283002/diff/1/chrome/app/chromeos_strings... chrome/app/chromeos_strings.grdp:5569: Manipulate settings that specify whether websites can use features such as geolocation, microphone, camera etc. nit: oxford comma after "camera" to match text style elsewhere
I'll wait till Raj chimes in before I send this in. https://codereview.chromium.org/2495283002/diff/1/chrome/app/chromeos_strings... File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2495283002/diff/1/chrome/app/chromeos_strings... chrome/app/chromeos_strings.grdp:5569: Manipulate settings that specify whether websites can use features such as geolocation, microphone, camera etc. On 2016/11/14 11:14:33, Andrew T Wilson (Slow) wrote: > nit: oxford comma after "camera" to match text style elsewhere I copy pasted the text Raj gave me :S But I agree, and done.
lgtm On 2016/11/14 11:24:06, Ivan Šandrk wrote: > I'll wait till Raj chimes in before I send this in. > > https://codereview.chromium.org/2495283002/diff/1/chrome/app/chromeos_strings... > File chrome/app/chromeos_strings.grdp (right): > > https://codereview.chromium.org/2495283002/diff/1/chrome/app/chromeos_strings... > chrome/app/chromeos_strings.grdp:5569: Manipulate settings that specify whether > websites can use features such as geolocation, microphone, camera etc. > On 2016/11/14 11:14:33, Andrew T Wilson (Slow) wrote: > > nit: oxford comma after "camera" to match text style elsewhere > > I copy pasted the text Raj gave me :S But I agree, and done.
The CQ bit was checked by isandrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from atwilson@chromium.org Link to the patchset: https://codereview.chromium.org/2495283002/#ps40001 (title: "Added 'Learn more' string")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by isandrk@chromium.org
The CQ bit was checked by isandrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sduraisamy@chromium.org, atwilson@chromium.org Link to the patchset: https://codereview.chromium.org/2495283002/#ps60001 (title: "Updated a string so it sounds more serious")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by isandrk@chromium.org
The CQ bit was checked by isandrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sduraisamy@chromium.org, atwilson@chromium.org Link to the patchset: https://codereview.chromium.org/2495283002/#ps80001 (title: "Added a missing fullstop")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== PS - Updated UI strings used during login in Public Sessions BUG=664951 ========== to ========== PS - Updated UI strings used during login in Public Sessions BUG=664951 Committed: https://crrev.com/7946fd64850d151fdb8fa449b131860c3c6ca878 Cr-Commit-Position: refs/heads/master@{#431988} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/7946fd64850d151fdb8fa449b131860c3c6ca878 Cr-Commit-Position: refs/heads/master@{#431988} |
