Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2495173003: [wrapper-tracing] Enable flag per default (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Enable flag per default Developer docs: http://bit.ly/chrome-trace-wrappers BUG=chromium:468240 Committed: https://crrev.com/7db18648678acf332a4cb7c91b831dd231e26d62 Cr-Commit-Position: refs/heads/master@{#431951}

Patch Set 1 #

Patch Set 2 : Fix test #

Messages

Total messages: 24 (14 generated)
Michael Lippautz
ptal let's wait for the branch cut, or try even before?
4 years, 1 month ago (2016-11-14 14:00:28 UTC) #12
Hannes Payer (out of office)
This is amazing! LGTM
4 years, 1 month ago (2016-11-14 17:48:44 UTC) #13
jochen (gone - plz use gerrit)
let's do this now. lgtm
4 years, 1 month ago (2016-11-14 17:50:01 UTC) #14
Marcel Hlopko
I want a LGTM on this one too :)
4 years, 1 month ago (2016-11-14 17:50:50 UTC) #15
Michael Lippautz
Giving this a go now. Let's see how far we get.
4 years, 1 month ago (2016-11-14 18:18:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495173003/20001
4 years, 1 month ago (2016-11-14 18:19:24 UTC) #18
haraken
LGTM
4 years, 1 month ago (2016-11-14 18:26:58 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 23:11:43 UTC) #21
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7db18648678acf332a4cb7c91b831dd231e26d62 Cr-Commit-Position: refs/heads/master@{#431951}
4 years, 1 month ago (2016-11-14 23:22:42 UTC) #23
Michael Lippautz
4 years, 1 month ago (2016-11-15 13:25:40 UTC) #24
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2504603002/ by mlippautz@chromium.org.

The reason for reverting is: Revert for now, as v8 needs to roll with
incremental flag enabled and we don't want the roll to get stuck..

Powered by Google App Engine
This is Rietveld 408576698