third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp - Issue 2495173003: [wrapper-tracing] Enable flag per default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

Issue 2495173003: [wrapper-tracing] Enable flag per default (Closed)

Patch Set: Fix test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-in-files-expected.txt ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

index 87d977156751d3f4edeeadf7aa0a8acf9aea7979..7cd229e94869a520a1d88d9edc144235bd16908b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

@@ -317,7 +317,9 @@ class InterceptingScriptWrappableVisitor

virtual void markWrapper(const v8::PersistentBase<v8::Value>* handle) const {

*m_markedWrappers += 1;

- ScriptWrappableVisitor::markWrapper(handle);

+ // Do not actually mark this visitor, as this would call into v8, which

+ // would

+ // require executing an actual GC.

}

size_t numberOfMarkedWrappers() const { return *m_markedWrappers; }