Adds some error handling to the socket implementation.

Adds some error handling to the socket implementation.

I'm starting to try to track down the hang in socket_test in
a call to read() on Mac. We weren't checking that the calls
to set fds non-blocking were successful, so I'll start with
adding code to do that.

This CL also fixes the GN arm android build.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/43a506bcc8bc57662c5e348dbf1d4ad38f90e9db

[zra, 2016-11-11 20:51:50]

Description was changed from

==========
Adds some error handling to the socket implementation.
==========

to

==========
Adds some error handling to the socket implementation.

I'm starting to try to track down the hang in socket_test in
a call to read() on Mac. We weren't checking that the calls
to set fds non-blocking were successful, so I'll start with
adding code to do that.

This CL also fixes the GN arm android build.
==========

[zra, 2016-11-11 20:52:20]

zra@google.com changed reviewers:
+ asiva@google.com, johnmccutchan@google.com

[siva, 2016-11-11 22:58:56]

lgtm

https://codereview.chromium.org/2495003003/diff/40001/runtime/bin/eventhandle...
File runtime/bin/eventhandler_android.cc (right):

https://codereview.chromium.org/2495003003/diff/40001/runtime/bin/eventhandle...
runtime/bin/eventhandler_android.cc:90: FATAL("Failed to set pipe fd non
blocking\n");
Would it make sense to log the errno as a simple print inside
FDUtils::SetBlockingHelper to help debugging when this error happens.

[zra, 2016-11-12 05:15:00]

https://codereview.chromium.org/2495003003/diff/40001/runtime/bin/eventhandle...
File runtime/bin/eventhandler_android.cc (right):

https://codereview.chromium.org/2495003003/diff/40001/runtime/bin/eventhandle...
runtime/bin/eventhandler_android.cc:90: FATAL("Failed to set pipe fd non
blocking\n");
On 2016/11/11 22:58:56, siva wrote:
> Would it make sense to log the errno as a simple print inside
> FDUtils::SetBlockingHelper to help debugging when this error happens.

Done.

[zra, 2016-11-12 05:15:19]

Description was changed from

==========
Adds some error handling to the socket implementation.

I'm starting to try to track down the hang in socket_test in
a call to read() on Mac. We weren't checking that the calls
to set fds non-blocking were successful, so I'll start with
adding code to do that.

This CL also fixes the GN arm android build.
==========

to

==========
Adds some error handling to the socket implementation.

I'm starting to try to track down the hang in socket_test in
a call to read() on Mac. We weren't checking that the calls
to set fds non-blocking were successful, so I'll start with
adding code to do that.

This CL also fixes the GN arm android build.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/43a506bcc8bc57662c5e348dbf1d4ad38f90e9db
==========

[zra, 2016-11-12 05:15:20]

Committed patchset #4 (id:60001) manually as
43a506bcc8bc57662c5e348dbf1d4ad38f90e9db (presubmit successful).