tools/gn.py - Issue 2495003003: Adds some error handling to the socket implementation. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(2)

My Issues | Starred Open | Closed | All

Unified Diff: tools/gn.py

Issue 2495003003: Adds some error handling to the socket implementation. (Closed)

Patch Set: Add perror calls for fcntl Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « runtime/bin/socket_macos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/gn.py

diff --git a/tools/gn.py b/tools/gn.py

index 0a385f3ce87334444b23abb86be9bfde683358f3..2ff3bc27f333d4989ef172e19693bda1d2b37eca 100755

--- a/tools/gn.py

+++ b/tools/gn.py

@@ -87,8 +87,14 @@ def to_gn_args(args, mode, arch, target_os):

gn_args['dart_use_tcmalloc'] = (gn_args['target_os'] == 'linux'

and not args.asan)

- if gn_args['target_cpu'].startswith('arm'):

+ # Force -mfloat-abi=hard and -mfpu=neon on Linux as we're specifying

+ # a gnueabihf compiler in //build/toolchain/linux BUILD.gn.

+ # TODO(zra): This will likely need some adjustment to build for armv6 etc.

+ hard_float = (gn_args['target_cpu'].startswith('arm') and

+ gn_args['target_os'] == 'linux')

+ if hard_float:

gn_args['arm_float_abi'] = 'hard'

+ gn_args['arm_use_neon'] = True

gn_args['is_debug'] = mode == 'debug'

gn_args['is_release'] = mode == 'release'

« no previous file with comments | « runtime/bin/socket_macos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698