Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2494983003: Mojo C++ bindings: switch device/vr mojom target to use STL/WTF types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, Ken Russell (switch to Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch device/vr mojom target to use STL/WTF types. BUG=624136 Committed: https://crrev.com/f710cf4b0c3daba89f78645226a13404386b7c17 Cr-Commit-Position: refs/heads/master@{#431910}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M device/vr/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/vr/android/gvr/gvr_device.cc View 1 2 3 chunks +15 lines, -15 lines 0 comments Download
M device/vr/test/fake_vr_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRFrameData.cpp View 1 2 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRPose.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRStageParameters.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (16 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-11 21:35:17 UTC) #6
Ken Russell (switch to Gerrit)
bajones@ should review this.
4 years, 1 month ago (2016-11-11 21:38:35 UTC) #9
bajones
On 2016/11/11 21:38:35, Ken Russell wrote: > bajones@ should review this. LGTM. I was wondering ...
4 years, 1 month ago (2016-11-11 21:54:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494983003/20001
4 years, 1 month ago (2016-11-11 21:57:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/162937) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 1 month ago (2016-11-11 22:16:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494983003/40001
4 years, 1 month ago (2016-11-12 00:03:12 UTC) #18
haraken
LGTM
4 years, 1 month ago (2016-11-12 01:33:02 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/330591)
4 years, 1 month ago (2016-11-12 02:30:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494983003/40001
4 years, 1 month ago (2016-11-14 16:59:51 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-14 19:50:42 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 20:10:24 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f710cf4b0c3daba89f78645226a13404386b7c17
Cr-Commit-Position: refs/heads/master@{#431910}

Powered by Google App Engine
This is Rietveld 408576698