components/suggestions/suggestions_service.cc - Issue 2494873003: [Sync] Allow sync start without sign-in if the local sync backend is on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/suggestions_service.cc

Issue 2494873003: [Sync] Allow sync start without sign-in if the local sync backend is on. (Closed)

Patch Set: Merge pref changes from https://codereview.chromium.org/2528163002/. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/suggestions/suggestions_service.cc

diff --git a/components/suggestions/suggestions_service.cc b/components/suggestions/suggestions_service.cc

index 47072e811b4356c16219bc1bccad12bbd57368ba..8df253f8e8b20f7aabedf4d0730c8e196dad05d8 100644

--- a/components/suggestions/suggestions_service.cc

+++ b/components/suggestions/suggestions_service.cc

@@ -66,7 +66,7 @@ enum SyncState {

};

SyncState GetSyncState(syncer::SyncService* sync) {

- if (!sync || !sync->CanSyncStart())

+ if (!sync || !sync->CanSyncStart() || sync->IsLocalSyncEnabled())

return SYNC_OR_HISTORY_SYNC_DISABLED;

if (!sync->IsSyncActive() || !sync->ConfigurationDone())

return NOT_INITIALIZED_ENABLED;