Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: components/browser_sync/profile_sync_service_unittest.cc

Issue 2494873003: [Sync] Allow sync start without sign-in if the local sync backend is on. (Closed)
Patch Set: Merge pref changes from https://codereview.chromium.org/2528163002/. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_service_unittest.cc
diff --git a/components/browser_sync/profile_sync_service_unittest.cc b/components/browser_sync/profile_sync_service_unittest.cc
index a074ec3b9e6c16199d2ee5b3804026c2e8a2da07..416ce3d6ed8cca15bb7f4279b49a8004178f2e34 100644
--- a/components/browser_sync/profile_sync_service_unittest.cc
+++ b/components/browser_sync/profile_sync_service_unittest.cc
@@ -249,14 +249,24 @@ class ProfileSyncServiceTest : public ::testing::Test {
base::MakeUnique<syncer::FakeDataTypeController>(syncer::BOOKMARKS));
}
-#if defined(OS_WIN) || defined(OS_MACOSX) || \
- (defined(OS_LINUX) && !defined(OS_CHROMEOS))
void CreateServiceWithoutSignIn() {
Nicolas Zea 2016/12/15 00:37:28 nit: for clarity would be good to rename to Create
pastarmovj 2016/12/16 17:04:48 Done.
- CreateService(ProfileSyncService::AUTO_START);
- signin_manager()->SignOut(signin_metrics::SIGNOUT_TEST,
- signin_metrics::SignoutDelete::IGNORE_METRIC);
+ component_factory_ = profile_sync_service_bundle_.component_factory();
+ ProfileSyncServiceBundle::SyncClientBuilder builder(
+ &profile_sync_service_bundle_);
+ ProfileSyncService::InitParams init_params =
+ profile_sync_service_bundle_.CreateBasicInitParams(
+ ProfileSyncService::AUTO_START, builder.Build());
+
+ prefs()->SetBoolean(syncer::prefs::kEnableLocalSyncBackend, true);
+ init_params.local_sync_backend_folder =
+ base::FilePath(FILE_PATH_LITERAL("dummyPath"));
+ init_params.oauth2_token_service = nullptr;
+ init_params.gaia_cookie_manager_service = nullptr;
+
+ service_ = base::MakeUnique<ProfileSyncService>(std::move(init_params));
+ service_->RegisterDataTypeController(
+ base::MakeUnique<syncer::FakeDataTypeController>(syncer::BOOKMARKS));
}
-#endif
void ShutdownAndDeleteService() {
if (service_)
@@ -410,6 +420,19 @@ TEST_F(ProfileSyncServiceTest, SuccessfulInitialization) {
EXPECT_TRUE(service()->IsSyncActive());
}
+// Verify a successful initialization.
+TEST_F(ProfileSyncServiceTest, SuccessfulLocalBackendInitialization) {
+ prefs()->SetManagedPref(syncer::prefs::kSyncManaged,
+ new base::FundamentalValue(false));
+ IssueTestTokens();
+ CreateServiceWithoutSignIn();
+ ExpectDataTypeManagerCreation(1, GetDefaultConfigureCalledCallback());
+ ExpectSyncEngineCreation(1);
+ InitializeForNthSync();
+ EXPECT_FALSE(service()->IsManaged());
+ EXPECT_TRUE(service()->IsSyncActive());
+}
+
// Verify that an initialization where first setup is not complete does not
// start up the backend.
TEST_F(ProfileSyncServiceTest, NeedsConfirmation) {

Powered by Google App Engine
This is Rietveld 408576698