Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2494853003: Remove some unused history resources on iOS (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years ago
CC:
chromium-reviews, Patrick Dubroy, dbeam+watch-history_chromium.org, pam+watch_chromium.org, mac-reviews_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unused history resources on iOS R=jyquinn@chromium.org BUG= Committed: https://crrev.com/87307d2447a4058c9942c07e20db31b54c1a72ab Cr-Commit-Position: refs/heads/master@{#434921}

Patch Set 1 #

Patch Set 2 : add back URL constants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5867 lines) Patch
D ios/chrome/app/resources/history/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ios/chrome/app/resources/history/alert_overlay.css View 1 chunk +0 lines, -20 lines 0 comments Download
D ios/chrome/app/resources/history/alert_overlay.html View 1 chunk +0 lines, -13 lines 0 comments Download
D ios/chrome/app/resources/history/history.css View 1 chunk +0 lines, -643 lines 0 comments Download
D ios/chrome/app/resources/history/history.html View 1 chunk +0 lines, -116 lines 0 comments Download
D ios/chrome/app/resources/history/history.js View 1 chunk +0 lines, -2361 lines 0 comments Download
D ios/chrome/app/resources/history/history_mobile.css View 1 chunk +0 lines, -353 lines 0 comments Download
D ios/chrome/app/resources/history/other_devices.js View 1 chunk +0 lines, -575 lines 0 comments Download
M ios/chrome/app/resources/ios_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
D ios/chrome/browser/ui/webui/history/BUILD.gn View 1 chunk +0 lines, -51 lines 0 comments Download
D ios/chrome/browser/ui/webui/history/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ios/chrome/browser/ui/webui/history/browsing_history_handler.h View 1 chunk +0 lines, -235 lines 0 comments Download
D ios/chrome/browser/ui/webui/history/browsing_history_handler.cc View 1 chunk +0 lines, -860 lines 0 comments Download
D ios/chrome/browser/ui/webui/history/favicon_source.h View 1 chunk +0 lines, -136 lines 0 comments Download
D ios/chrome/browser/ui/webui/history/favicon_source.cc View 1 chunk +0 lines, -183 lines 0 comments Download
D ios/chrome/browser/ui/webui/history/history_ui.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ios/chrome/browser/ui/webui/history/history_ui.mm View 1 chunk +0 lines, -167 lines 0 comments Download
D ios/chrome/browser/ui/webui/history/metrics_handler.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ios/chrome/browser/ui/webui/history/metrics_handler.cc View 1 chunk +0 lines, -66 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Dan Beam
4 years ago (2016-11-21 20:23:12 UTC) #2
Jackie Quinn
On 2016/11/21 20:23:12, Dan Beam wrote: history_ui.h is still included downstream, and that should be ...
4 years ago (2016-11-21 22:45:46 UTC) #5
Dan Beam
On 2016/11/21 22:45:46, Jackie Quinn wrote: > On 2016/11/21 20:23:12, Dan Beam wrote: > > ...
4 years ago (2016-11-22 00:19:12 UTC) #8
Jackie Quinn
lgtm. +eugene for ios_resources.grd
4 years ago (2016-11-23 19:37:14 UTC) #10
Eugene But (OOO till 7-30)
ios_resources.grd lgtm
4 years ago (2016-11-23 19:39:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494853003/20001
4 years ago (2016-11-23 21:54:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on ...
4 years ago (2016-11-23 23:56:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494853003/20001
4 years ago (2016-11-29 05:36:11 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 07:04:13 UTC) #20
commit-bot: I haz the power
4 years ago (2016-11-29 07:07:52 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/87307d2447a4058c9942c07e20db31b54c1a72ab
Cr-Commit-Position: refs/heads/master@{#434921}

Powered by Google App Engine
This is Rietveld 408576698