Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ios/chrome/browser/ui/webui/history/metrics_handler.h

Issue 2494853003: Remove some unused history resources on iOS (Closed)
Patch Set: add back URL constants Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/webui/history/metrics_handler.h
diff --git a/ios/chrome/browser/ui/webui/history/metrics_handler.h b/ios/chrome/browser/ui/webui/history/metrics_handler.h
deleted file mode 100644
index 04ae6e5627035d61a0573e4783018987bfa938e7..0000000000000000000000000000000000000000
--- a/ios/chrome/browser/ui/webui/history/metrics_handler.h
+++ /dev/null
@@ -1,51 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef IOS_CHROME_BROWSER_UI_WEBUI_HISTORY_METRICS_HANDLER_H_
-#define IOS_CHROME_BROWSER_UI_WEBUI_HISTORY_METRICS_HANDLER_H_
-
-#include "base/compiler_specific.h"
-#include "base/macros.h"
-#include "ios/web/public/webui/web_ui_ios_message_handler.h"
-
-///////////////////////////////////////////////////////////////////////////////
-// MetricsHandler
-
-// Let the page contents record UMA actions. Only use when you can't do it from
-// C++. For example, we currently use it to let the NTP log the position of the
-// Most Visited or Bookmark the user clicked on, as we don't get that
-// information through RequestOpenURL. You will need to update the metrics
-// dashboard with the action names you use, as our processor won't catch that
-// information (treat it as RecordComputedMetrics)
-
-namespace base {
-class ListValue;
-}
-
-class MetricsHandler : public web::WebUIIOSMessageHandler {
- public:
- MetricsHandler();
- ~MetricsHandler() override;
-
- // WebUIIOSMessageHandler implementation.
- void RegisterMessages() override;
-
- // Callback for the "metricsHandler:recordAction" message. This records a
- // user action.
- void HandleRecordAction(const base::ListValue* args);
-
- // TODO(dbeam): http://crbug.com/104338
-
- // Callback for the "metricsHandler:recordInHistogram" message. This records
- // into a histogram. |args| contains the histogram name, the value to record,
- // and the maximum allowed value, which can be at most 4000. The histogram
- // will use at most 100 buckets, one for each 1, 10, or 100 different values,
- // depending on the maximum value.
- void HandleRecordInHistogram(const base::ListValue* args);
-
- private:
- DISALLOW_COPY_AND_ASSIGN(MetricsHandler);
-};
-
-#endif // IOS_CHROME_BROWSER_UI_WEBUI_HISTORY_METRICS_HANDLER_H_
« no previous file with comments | « ios/chrome/browser/ui/webui/history/history_ui.mm ('k') | ios/chrome/browser/ui/webui/history/metrics_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698