Stop disabling warning 4595 - inline operator new

Stop disabling warning 4595 - inline operator new

ICU used to define operator new/delete inline, but it no longer does
so we don't need to suppress this VS 2015/clang warning anymore.

http://bugs.icu-project.org/trac/ticket/11122

BUG=593448
Committed: https://crrev.com/c6e883ee8cf3b20541b256b9a2154af03445a3fc
Cr-Commit-Position: refs/heads/master@{#431369}

[brucedawson, 2016-11-10 19:20:42]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 19:21:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-11-10 21:18:56]

brucedawson@chromium.org changed reviewers:
+ thakis@chromium.org

[brucedawson, 2016-11-10 21:18:56]

PTAL

Now that http://bugs.icu-project.org/trac/ticket/11122 is fixed we can stop
disabling this warning.

Also, we should be able to remove these two lines from ICU's BUILD.gn file:

"-Wno-inline-new-delete",
"-Wno-implicit-exception-spec-mismatch"

[Nico, 2016-11-10 21:20:04]

lgtm

On 2016/11/10 21:18:56, brucedawson wrote:
> PTAL
> 
> Now that http://bugs.icu-project.org/trac/ticket/11122 is fixed we can stop
> disabling this warning.
> 
> Also, we should be able to remove these two lines from ICU's BUILD.gn file:
> 
> "-Wno-inline-new-delete",
> "-Wno-implicit-exception-spec-mismatch"

Are you writing a CL for that too?

[brucedawson, 2016-11-10 21:21:58]

> Are you writing a CL for that too?

I haven't started, so take it if you want, especially if you're already setup
for doing ICU contributions (I'm not).

[Nico, 2016-11-10 21:30:56]

On Thu, Nov 10, 2016 at 1:21 PM, <brucedawson@chromium.org> wrote:

> > Are you writing a CL for that too?
>
> I haven't started, so take it if you want, especially if you're already
> setup
> for doing ICU contributions (I'm not).
>

I think `cd third_party/icu; git checkout -b foo; vim; git commit -am; git
cl upload` is all it takes (?)


>
> https://codereview.chromium.org/2494793002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brucedawson, 2016-11-10 21:32:16]

> I think `cd third_party/icu; git checkout -b foo; vim; git commit -am; git
> cl upload` is all it takes (?)

Okay, I'll do it. Less warning disabling is good.

[commit-bot: I haz the power, 2016-11-10 21:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:41:45]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-11-10 21:46:15]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:47:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 21:53:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-10 23:09:59]

Description was changed from

==========
Stop disabling warning 4595 - inline operator new

ICU used to define operator new/delete inline, but it no longer does
so we don't need to suppress this VS 2015/clang warning anymore.

http://bugs.icu-project.org/trac/ticket/11122

BUG=593448
==========

to

==========
Stop disabling warning 4595 - inline operator new

ICU used to define operator new/delete inline, but it no longer does
so we don't need to suppress this VS 2015/clang warning anymore.

http://bugs.icu-project.org/trac/ticket/11122

BUG=593448

Committed: https://crrev.com/c6e883ee8cf3b20541b256b9a2154af03445a3fc
Cr-Commit-Position: refs/heads/master@{#431369}
==========

[commit-bot: I haz the power, 2016-11-10 23:10:00]

Patchset 1 (id:??) landed as
https://crrev.com/c6e883ee8cf3b20541b256b9a2154af03445a3fc
Cr-Commit-Position: refs/heads/master@{#431369}

[brucedawson, 2016-11-14 19:07:56]

On 2016/11/10 23:10:00, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/c6e883ee8cf3b20541b256b9a2154af03445a3fc
> Cr-Commit-Position: refs/heads/master@{#431369}

See in-progress CL https://codereview.chromium.org/2492553006 for the icu
specific changes.