Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1643)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 2494793002: Stop disabling warning 4595 - inline operator new (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 3e14f524f70064a1f8ec31608a1c232ab9ff4b75..a1fec7949e311142968a301f806d9efc96a4c7fe 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -905,12 +905,6 @@ config("default_warnings") {
# C4312 is a VS 2015 64-bit warning for integer to larger pointer.
# TODO(brucedawson): fix warnings, crbug.com/554200
"/wd4312",
-
- # TODO(brucedawson): http://crbug.com/593448 - C4595 is an 'illegal
- # inline operator new' warning that is new in VS 2015 Update 2.
- # This is equivalent to clang's no-inline-new-delete warning.
- # See http://bugs.icu-project.org/trac/ticket/11122
- "/wd4595",
]
if (current_cpu == "x86") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698