Reland of mojo VR interface simpified.

Reland of mojo VR interface simpified.
Fix the reason of revert of Werror : https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5867/steps/compile/logs/stdio
Fix this by adding static_cast<unsigned> in the GetNumberOfConnectedDevices() function which in vr_device_manager.cc file.

Original issue's description:
mojo VR interface simplified

Since mojo interface prefer API without index transfer, current
implementation should be modified.

According to dcheng@ and bajones@ comments, WebVR implementation should
modified to let display/frame communicate directly so that index
parameters are no longer need.

BUG=652080
R=bajons@chromium.org,dcheng@chromium.org,clamy@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/afc619b02bc3fa771855c768f92057052765bea0
Cr-Commit-Position: refs/heads/master@{#431493}

[shaobo.yan, 2016-11-10 15:57:06]

Description was changed from

==========
Reland of mojo VR interface simpified.
Fix the reason of revert of Werror :
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5867/steps/co...
Fix this by adding static_cast<unsigned> in the GetNumberOfConnectedDevices()
function which in vr_device_manager.cc file.

Original issue's description:
mojo VR interface simplified

Since mojo interface prefer API without index transfer, current
implementation should be modified.

According to dcheng@ and bajones@ comments, WebVR implementation should
modified to let display/frame communicate directly so that index
parameters are no longer need.

BUG=652080
R=bajons@chromium.org,dcheng@chromium.org,clamy@chromium.org
==========

to

==========
Reland of mojo VR interface simpified.
Fix the reason of revert of Werror :
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5867/steps/co...
Fix this by adding static_cast<unsigned> in the GetNumberOfConnectedDevices()
function which in vr_device_manager.cc file.

Original issue's description:
mojo VR interface simplified

Since mojo interface prefer API without index transfer, current
implementation should be modified.

According to dcheng@ and bajones@ comments, WebVR implementation should
modified to let display/frame communicate directly so that index
parameters are no longer need.

BUG=652080
R=bajons@chromium.org,dcheng@chromium.org,clamy@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[shaobo.yan, 2016-11-10 15:57:53]

Description was changed from

==========
Reland of mojo VR interface simpified.
Fix the reason of revert of Werror :
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5867/steps/co...
Fix this by adding static_cast<unsigned> in the GetNumberOfConnectedDevices()
function which in vr_device_manager.cc file.

Original issue's description:
mojo VR interface simplified

Since mojo interface prefer API without index transfer, current
implementation should be modified.

According to dcheng@ and bajones@ comments, WebVR implementation should
modified to let display/frame communicate directly so that index
parameters are no longer need.

BUG=652080
R=bajons@chromium.org,dcheng@chromium.org,clamy@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Reland of mojo VR interface simpified.
Fix the reason of revert of Werror :
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5867/steps/co...
Fix this by adding static_cast<unsigned> in the GetNumberOfConnectedDevices()
function which in vr_device_manager.cc file.

Original issue's description:
mojo VR interface simplified

Since mojo interface prefer API without index transfer, current
implementation should be modified.

According to dcheng@ and bajones@ comments, WebVR implementation should
modified to let display/frame communicate directly so that index
parameters are no longer need.

BUG=652080
R=bajons@chromium.org,dcheng@chromium.org,clamy@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[shaobo.yan, 2016-11-10 15:57:53]

shaobo.yan@intel.com changed reviewers:
+ bajones@chromium.org
- bajons@chromium.org

[shaobo.yan, 2016-11-10 16:01:01]

it seems that bots don't check out some Werror and cause the revert. Now fix
it.Sorry about that. 
bajones@ and dcheng@ PTAL.
clamy@ PTAL content part.

The original patch is here: https://codereview.chromium.org/2420743003/

[clamy, 2016-11-10 17:18:05]

content/ lgtm.

[bajones, 2016-11-10 17:47:34]

On 2016/11/10 17:18:05, clamy wrote:
> content/ lgtm.

display/vr and modules/vr LGTM

[dcheng, 2016-11-10 17:55:21]

Would it be possible to upload the original patch as one patchset, and the
updated diff as another? It makes it easier to review.

As for the difference... we have some narrowing warnings disabled on some
platforms. In this case, maybe
https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=0&l=1002
is applying, but I'm not sure.

[shaobo.yan, 2016-11-11 00:48:20]

On 2016/11/10 17:55:21, dcheng wrote:
> Would it be possible to upload the original patch as one patchset, and the
> updated diff as another? It makes it easier to review.
> 
> As for the difference... we have some narrowing warnings disabled on some
> platforms. In this case, maybe
>
https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=0&l=1002
> is applying, but I'm not sure.

dcheng@ Thx for suggestion, and patch set 2 is the original patch patch set 3 is
the modification. Since mojo doesn't support size_t type and the number of
devices limited to 0XFFFFFFFF, unsigned int is enough, so I used static_cast.

About the difference...I'm really feel curious why commit bots result is
different. I try to enable these narrow warning but it seems it generate warning
error before this refactro patch. So how could I modify my build flag to avoid
the similar situation?

[dcheng, 2016-11-11 00:51:29]

lgtm

As for the compiler errors, it's because this warning isn't enabled by default,
even with -Wall -Wextra:
https://bugs.chromium.org/p/chromium/issues/detail?id=588506

The Windows bots build with a slightly different set of flags, so it's not too
surprising it would work on Linux64 but not Win64.

[shaobo.yan, 2016-11-11 00:52:55]

On 2016/11/11 00:51:29, dcheng wrote:
> lgtm
> 
> As for the compiler errors, it's because this warning isn't enabled by
default,
> even with -Wall -Wextra:
> https://bugs.chromium.org/p/chromium/issues/detail?id=588506
> 
> The Windows bots build with a slightly different set of flags, so it's not too
> surprising it would work on Linux64 but not Win64.

Thx!

[shaobo.yan, 2016-11-11 02:27:13]

The CQ bit was checked by shaobo.yan@intel.com

[shaobo.yan, 2016-11-11 02:27:14]

The patchset sent to the CQ was uploaded after l-g-t-m from clamy@chromium.org,
bajones@chromium.org
Link to the patchset: https://codereview.chromium.org/2494733002/#ps40001
(title: "Fix Werror")

[commit-bot: I haz the power, 2016-11-11 02:28:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 04:09:47]

Description was changed from

==========
Reland of mojo VR interface simpified.
Fix the reason of revert of Werror :
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5867/steps/co...
Fix this by adding static_cast<unsigned> in the GetNumberOfConnectedDevices()
function which in vr_device_manager.cc file.

Original issue's description:
mojo VR interface simplified

Since mojo interface prefer API without index transfer, current
implementation should be modified.

According to dcheng@ and bajones@ comments, WebVR implementation should
modified to let display/frame communicate directly so that index
parameters are no longer need.

BUG=652080
R=bajons@chromium.org,dcheng@chromium.org,clamy@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Reland of mojo VR interface simpified.
Fix the reason of revert of Werror :
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5867/steps/co...
Fix this by adding static_cast<unsigned> in the GetNumberOfConnectedDevices()
function which in vr_device_manager.cc file.

Original issue's description:
mojo VR interface simplified

Since mojo interface prefer API without index transfer, current
implementation should be modified.

According to dcheng@ and bajones@ comments, WebVR implementation should
modified to let display/frame communicate directly so that index
parameters are no longer need.

BUG=652080
R=bajons@chromium.org,dcheng@chromium.org,clamy@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-11-11 04:09:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-11 04:13:20]

Description was changed from

==========
Reland of mojo VR interface simpified.
Fix the reason of revert of Werror :
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5867/steps/co...
Fix this by adding static_cast<unsigned> in the GetNumberOfConnectedDevices()
function which in vr_device_manager.cc file.

Original issue's description:
mojo VR interface simplified

Since mojo interface prefer API without index transfer, current
implementation should be modified.

According to dcheng@ and bajones@ comments, WebVR implementation should
modified to let display/frame communicate directly so that index
parameters are no longer need.

BUG=652080
R=bajons@chromium.org,dcheng@chromium.org,clamy@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Reland of mojo VR interface simpified.
Fix the reason of revert of Werror :
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5867/steps/co...
Fix this by adding static_cast<unsigned> in the GetNumberOfConnectedDevices()
function which in vr_device_manager.cc file.

Original issue's description:
mojo VR interface simplified

Since mojo interface prefer API without index transfer, current
implementation should be modified.

According to dcheng@ and bajones@ comments, WebVR implementation should
modified to let display/frame communicate directly so that index
parameters are no longer need.

BUG=652080
R=bajons@chromium.org,dcheng@chromium.org,clamy@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/afc619b02bc3fa771855c768f92057052765bea0
Cr-Commit-Position: refs/heads/master@{#431493}
==========

[commit-bot: I haz the power, 2016-11-11 04:13:22]

Patchset 3 (id:??) landed as
https://crrev.com/afc619b02bc3fa771855c768f92057052765bea0
Cr-Commit-Position: refs/heads/master@{#431493}