Reland of mojo VR interface simpified.

device/vr/vr_service_impl_unittest.cc

Index: device/vr/vr_service_impl_unittest.cc
diff --git a/device/vr/vr_service_impl_unittest.cc b/device/vr/vr_service_impl_unittest.cc
index 300bf0dbfb960c8fc738333a2253a3fca33e7504..f0b8ce276d60365dc478b19496d4744c5d9a72f4 100644
--- a/device/vr/vr_service_impl_unittest.cc
+++ b/device/vr/vr_service_impl_unittest.cc
@@ -17,28 +17,8 @@ using ::testing::Mock;
 
 namespace device {
 
-class MockVRServiceClient : public VRServiceClient {
- public:
-  MOCK_METHOD1(OnDisplayChanged, void(const VRDisplay& display));
-  void OnDisplayChanged(VRDisplayPtr display) override {
-    OnDisplayChanged(*display);
-    last_display_ = std::move(display);
-  }
-
-  MOCK_METHOD1(OnExitPresent, void(uint32_t index));
-
-  MOCK_METHOD1(OnDisplayConnected, void(const VRDisplay& display));
-  void OnDisplayConnected(VRDisplayPtr display) override {
-    OnDisplayConnected(*display);
-    last_display_ = std::move(display);
-  }
-  void OnDisplayDisconnected(unsigned index) override {}
-
-  const VRDisplayPtr& LastDisplay() { return last_display_; }
-
- private:
-  VRDisplayPtr last_display_;
-};
+// TODO(shaobo.yan@intel.com) : Update the whole unittest.
+class MockVRServiceClient : public mojom::VRServiceClient {};
 
 class VRServiceTestBinding {
  public:
@@ -47,10 +27,19 @@ class VRServiceTestBinding {
     service_impl_.reset(new VRServiceImpl());
     service_impl_->Bind(std::move(request));
 
-    VRServiceClientPtr client_ptr;
-    client_binding_.reset(new mojo::Binding<VRServiceClient>(
-        &mock_client_, mojo::GetProxy(&client_ptr)));
-    service_impl_->SetClient(std::move(client_ptr));
+    client_binding_.reset(new mojo::Binding<mojom::VRServiceClient>(
+        mock_client_, mojo::GetProxy(&client_ptr_)));
+  }
+
+  void SetClient() {
+    service_impl_->SetClient(
+        std::move(client_ptr_),
+        base::Bind(&device::VRServiceTestBinding::SetNumberOfDevices,
+                   base::Unretained(this)));
+  }
+
+  void SetNumberOfDevices(unsigned int number_of_devices) {
+    number_of_devices_ = number_of_devices;
   }
 
   void Close() {
@@ -58,15 +47,17 @@ class VRServiceTestBinding {
     service_impl_.reset();
   }
 
-  MockVRServiceClient& client() { return mock_client_; }
+  MockVRServiceClient* client() { return mock_client_; }
   VRServiceImpl* service() { return service_impl_.get(); }
 
  private:
+  mojom::VRServiceClientPtr client_ptr_;
   std::unique_ptr<VRServiceImpl> service_impl_;
-  mojo::InterfacePtr<VRService> service_ptr_;
+  mojo::InterfacePtr<mojom::VRService> service_ptr_;
 
-  MockVRServiceClient mock_client_;
-  std::unique_ptr<mojo::Binding<VRServiceClient>> client_binding_;
+  MockVRServiceClient* mock_client_;
+  std::unique_ptr<mojo::Binding<mojom::VRServiceClient>> client_binding_;
+  unsigned int number_of_devices_;
 
   DISALLOW_COPY_AND_ASSIGN(VRServiceTestBinding);
 };
@@ -86,13 +77,13 @@ class VRServiceImplTest : public testing::Test {
   void TearDown() override { base::RunLoop().RunUntilIdle(); }
 
   std::unique_ptr<VRServiceTestBinding> BindService() {
-    return std::unique_ptr<VRServiceTestBinding>(new VRServiceTestBinding());
+    auto test_binding = base::WrapUnique(new VRServiceTestBinding());
+    test_binding->SetClient();
+    return test_binding;
   }
 
   size_t ServiceCount() { return device_manager_->services_.size(); }
 
-  bool presenting() { return !!device_manager_->presenting_service_; }
-
   base::MessageLoop message_loop_;
   FakeVRDeviceProvider* provider_;
   std::unique_ptr<VRDeviceManager> device_manager_;
@@ -122,86 +113,4 @@ TEST_F(VRServiceImplTest, DeviceManagerRegistration) {
   EXPECT_EQ(0u, ServiceCount());
 }
 
-// Ensure that DeviceChanged calls are dispatched to all active services.
-TEST_F(VRServiceImplTest, DeviceChangedDispatched) {
-  std::unique_ptr<VRServiceTestBinding> service_1 = BindService();
-  std::unique_ptr<VRServiceTestBinding> service_2 = BindService();
-
-  EXPECT_CALL(service_1->client(), OnDisplayChanged(_));
-  EXPECT_CALL(service_2->client(), OnDisplayChanged(_));
-
-  std::unique_ptr<FakeVRDevice> device(new FakeVRDevice(provider_));
-  device_manager_->OnDeviceChanged(device->GetVRDevice());
-
-  base::RunLoop().RunUntilIdle();
-
-  EXPECT_EQ(device->id(), service_1->client().LastDisplay()->index);
-  EXPECT_EQ(device->id(), service_2->client().LastDisplay()->index);
-}
-
-// Ensure that presenting devices cannot be accessed by other services
-TEST_F(VRServiceImplTest, DevicePresentationIsolation) {
-  std::unique_ptr<VRServiceTestBinding> service_1 = BindService();
-  std::unique_ptr<VRServiceTestBinding> service_2 = BindService();
-
-  std::unique_ptr<FakeVRDevice> device(new FakeVRDevice(provider_));
-  provider_->AddDevice(device.get());
-
-  // Ensure the device manager has seen the fake device
-  device_manager_->GetVRDevices();
-
-  // When not presenting either service should be able to access the device
-  EXPECT_EQ(device.get(), VRDeviceManager::GetAllowedDevice(
-                              service_1->service(), device->id()));
-  EXPECT_EQ(device.get(), VRDeviceManager::GetAllowedDevice(
-                              service_2->service(), device->id()));
-
-  // Begin presenting to the fake device with service 1
-  EXPECT_TRUE(device_manager_->RequestPresent(service_1->service(),
-                                              device->id(), true));
-
-  EXPECT_TRUE(presenting());
-
-  // Service 2 should not be able to present to the device while service 1
-  // is still presenting.
-  EXPECT_FALSE(device_manager_->RequestPresent(service_2->service(),
-                                               device->id(), true));
-
-  // Only the presenting service should be able to access the device
-  EXPECT_EQ(device.get(), VRDeviceManager::GetAllowedDevice(
-                              service_1->service(), device->id()));
-  EXPECT_EQ(nullptr, VRDeviceManager::GetAllowedDevice(service_2->service(),
-                                                       device->id()));
-
-  // Service 2 should not be able to exit presentation to the device
-  device_manager_->ExitPresent(service_2->service(), device->id());
-  EXPECT_TRUE(presenting());
-
-  // Service 1 should be able to exit the presentation it initiated.
-  device_manager_->ExitPresent(service_1->service(), device->id());
-  EXPECT_FALSE(presenting());
-
-  // Once presention had ended both services should be able to access the device
-  EXPECT_EQ(device.get(), VRDeviceManager::GetAllowedDevice(
-                              service_1->service(), device->id()));
-  EXPECT_EQ(device.get(), VRDeviceManager::GetAllowedDevice(
-                              service_2->service(), device->id()));
-}
-
-// Ensure that DeviceChanged calls are dispatched to all active services.
-TEST_F(VRServiceImplTest, DeviceConnectedDispatched) {
-  std::unique_ptr<VRServiceTestBinding> service_1 = BindService();
-  std::unique_ptr<VRServiceTestBinding> service_2 = BindService();
-
-  EXPECT_CALL(service_1->client(), OnDisplayConnected(_));
-  EXPECT_CALL(service_2->client(), OnDisplayConnected(_));
-
-  std::unique_ptr<FakeVRDevice> device(new FakeVRDevice(provider_));
-  device_manager_->OnDeviceConnectionStatusChanged(device.get(), true);
-
-  base::RunLoop().RunUntilIdle();
-
-  EXPECT_EQ(device->id(), service_1->client().LastDisplay()->index);
-  EXPECT_EQ(device->id(), service_2->client().LastDisplay()->index);
-}
 }