Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2494663003: Explicitly put serial port fd in non-blocking mode on Chrome OS. (Closed)

Created:
4 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Explicitly put serial port fd in non-blocking mode on Chrome OS. On Chrome OS the serial port is opened by the permission broker service, which does not open the file descriptor in non-blocking mode. Chrome should thus explicitly put the file descriptor in this mode to match the flags set on other platforms. Since r408467 we have relied on the file being in non-blocking mode to test for data available as soon as it is open. BUG=644017 Review-Url: https://codereview.chromium.org/2494513002 Cr-Commit-Position: refs/heads/master@{#431026} (cherry picked from commit 0366454d38a76aba066b183f2f8132a15e26b385) Committed: https://chromium.googlesource.com/chromium/src/+/7bc4382e2f3885ae85ea398de2e0d4013b0d2348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M device/serial/serial_io_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M device/serial/serial_io_handler_posix.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/serial/serial_io_handler_posix.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Reilly Grant (use Gerrit)
4 years, 1 month ago (2016-11-10 20:25:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7bc4382e2f3885ae85ea398de2e0d4013b0d2348.

Powered by Google App Engine
This is Rietveld 408576698