device/serial/serial_io_handler_posix.h - Issue 2494663003: Explicitly put serial port fd in non-blocking mode on Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/serial_io_handler_posix.h

Issue 2494663003: Explicitly put serial port fd in non-blocking mode on Chrome OS. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/serial/serial_io_handler_posix.h

diff --git a/device/serial/serial_io_handler_posix.h b/device/serial/serial_io_handler_posix.h

index b25f7c8731bc8c18cafca04025e70b6c9576cf8f..5657f36138097c3875af5b1706463823f38e9d5b 100644

--- a/device/serial/serial_io_handler_posix.h

+++ b/device/serial/serial_io_handler_posix.h

@@ -27,6 +27,7 @@ class SerialIoHandlerPosix : public SerialIoHandler,

void CancelReadImpl() override;

void CancelWriteImpl() override;

bool ConfigurePortImpl() override;

+ bool PostOpen() override;

bool Flush() const override;

serial::DeviceControlSignalsPtr GetControlSignals() const override;

bool SetControlSignals(

« no previous file with comments | « device/serial/serial_io_handler.cc ('k') | device/serial/serial_io_handler_posix.cc » ('j') | no next file with comments »