Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2494633005: Revert of [sync] "TwoClientBookmarksSyncTest.Sanity" is flaky (Closed)

Created:
4 years, 1 month ago by hiroshige
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sync] "TwoClientBookmarksSyncTest.Sanity" is flaky (patchset #2 id:40001 of https://codereview.chromium.org/2479313004/ ) Reason for revert: Suspected to cause TwoClientUssSyncTest.ConflictResolution flaky failures: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TwoClientUssSyncTest.ConflictResolution&testType=sync_integration_tests Original issue's description: > [sync] "TwoClientBookmarksSyncTest.Sanity" is flaky > > Reduce flakiness in TwoClientBookmarksSyncTest by: > 1) Reducing the nudge delay for sync to 1 ms > 2) Switching to BookmarksMatchChecker.Wait(), which isn't prone to the > "stale snapshot" race condition. > > Reducing the nudge delay applies to and should speed up all the sync > integration tests, not just the TwoClientBookmarks ones. > > Only pairs of > AwaitQuiescence|AwaitMutualSyncCycleCompletion > AllModelsMatch(Verifier?)() > > Were converted to use the new pattern. > > BUG=660655 > > R=zea@chromium.org, pavely@chromium.org > > Committed: https://crrev.com/3b8f13960ccb28bf854a91f05878b95529c32d79 > Cr-Commit-Position: refs/heads/master@{#431376} TBR=pavely@chromium.org,zea@chromium.org,pnoland@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=660655 Committed: https://crrev.com/09f9c8e02d8918a23099fc8d7402aa39f24ea1fe Cr-Commit-Position: refs/heads/master@{#431525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -215 lines) Patch
M chrome/browser/sync/test/integration/bookmarks_helper.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc View 82 chunks +254 lines, -127 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync/driver/sync_driver_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/sync_driver_switches.cc View 1 chunk +1 line, -8 lines 0 comments Download
M components/sync/engine/engine_components_factory.h View 2 chunks +0 lines, -6 lines 0 comments Download
M components/sync/engine/engine_components_factory_impl.cc View 3 chunks +3 lines, -25 lines 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl.h View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hiroshige
Created Revert of [sync] "TwoClientBookmarksSyncTest.Sanity" is flaky
4 years, 1 month ago (2016-11-11 08:28:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494633005/1
4 years, 1 month ago (2016-11-11 08:28:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 08:29:36 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 08:32:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09f9c8e02d8918a23099fc8d7402aa39f24ea1fe
Cr-Commit-Position: refs/heads/master@{#431525}

Powered by Google App Engine
This is Rietveld 408576698