Chromium Code Reviews
DescriptionRevert of [sync] "TwoClientBookmarksSyncTest.Sanity" is flaky (patchset #2 id:40001 of https://codereview.chromium.org/2479313004/ )
Reason for revert:
Suspected to cause TwoClientUssSyncTest.ConflictResolution flaky failures:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TwoClientUssSyncTest.ConflictResolution&testType=sync_integration_tests
Original issue's description:
> [sync] "TwoClientBookmarksSyncTest.Sanity" is flaky
>
> Reduce flakiness in TwoClientBookmarksSyncTest by:
> 1) Reducing the nudge delay for sync to 1 ms
> 2) Switching to BookmarksMatchChecker.Wait(), which isn't prone to the
> "stale snapshot" race condition.
>
> Reducing the nudge delay applies to and should speed up all the sync
> integration tests, not just the TwoClientBookmarks ones.
>
> Only pairs of
> AwaitQuiescence|AwaitMutualSyncCycleCompletion
> AllModelsMatch(Verifier?)()
>
> Were converted to use the new pattern.
>
> BUG=660655
>
> R=zea@chromium.org, pavely@chromium.org
>
> Committed: https://crrev.com/3b8f13960ccb28bf854a91f05878b95529c32d79
> Cr-Commit-Position: refs/heads/master@{#431376}
TBR=pavely@chromium.org,zea@chromium.org,pnoland@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660655
Committed: https://crrev.com/09f9c8e02d8918a23099fc8d7402aa39f24ea1fe
Cr-Commit-Position: refs/heads/master@{#431525}
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|